Skip to content

Implement using WPR namespace for all service variables #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@ in `values.yaml`.
## License activation

There are three ways the service can be activated:
1. During `docker build` by setting the `LICENSE_TICKET_ID` argument in Dockerfile or CLI (`--build-arg LICENSE_TICKET_ID=${MY_LOCAL_VARIABLE}`).
1. During `docker build` by setting the `WPR_LICENSE_TICKET_ID` argument in Dockerfile or CLI (`--build-arg WPR_LICENSE_TICKET_ID=${MY_LOCAL_VARIABLE}`).
2. Through the `values.yaml` config file (`licenseTicketID` parameter).
3. During chart deployment/upgrade CLI call using the flag:
```shell
--set licenseTicketID=${LICENSE_TICKET_ID}
--set licenseTicketID=${WPR_LICENSE_TICKET_ID}
```
provided that `LICENSE_TICKET_ID` is set in your environment.
provided that `WPR_LICENSE_TICKET_ID` is set in your environment.

> [!IMPORTANT]
> If you are attempting to build a production environment, it's recommended to use the custom Docker image with WProofreader Server instead of the public one published on Docker Hub. With the custom image, you won't need to activate the license on the container start. Thus, you just skip this step. Otherwise, you may face the issue with reaching the maximum allowed number of license activation attempts (by default, 25). In this case, you need to [contact support](https://webspellchecker.com/contact-us/) to extend/reset the license activation limit. Nevertheless, using the public image is acceptable for evaluation, testing and development purposes.
Expand Down
8 changes: 4 additions & 4 deletions manifests/deployment_http.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ spec:
- mountPath: /dictionaries
name: dictionaries-volume
env:
- name: PROTOCOL
- name: WPR_PROTOCOL
value: "2"
- name: WEB_PORT
- name: WPR_WEB_PORT
value: "80"
- name: VIRTUAL_DIR
- name: WPR_VIRTUAL_DIR
value: wscservice
- name: LICENSE_TICKET_ID
- name: WPR_LICENSE_TICKET_ID
valueFrom:
secretKeyRef:
name: wproofreader-app-lic
Expand Down
8 changes: 4 additions & 4 deletions manifests/deployment_https.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ spec:
- mountPath: /dictionaries
name: dictionaries-volume
env:
- name: PROTOCOL
- name: WPR_PROTOCOL
value: "1"
- name: WEB_PORT
- name: WPR_WEB_PORT
value: "443"
- name: VIRTUAL_DIR
- name: WPR_VIRTUAL_DIR
value: wscservice
- name: LICENSE_TICKET_ID
- name: WPR_LICENSE_TICKET_ID
valueFrom:
secretKeyRef:
name: wproofreader-app-lic
Expand Down
8 changes: 4 additions & 4 deletions wproofreader/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,16 @@ spec:
- mountPath: {{ .Values.dictionaries.mountPath | default "/dictionaries" }}
name: dictionaries-volume
env:
- name: PROTOCOL
- name: WPR_PROTOCOL
value: {{ if .Values.useHTTPS }}"1"{{ else }}"2"{{ end }}
- name: WEB_PORT
- name: WPR_WEB_PORT
value: {{ .Values.webPort | default (include "wproofreader.defaultWebPort" .) | quote }}
- name: VIRTUAL_DIR
- name: WPR_VIRTUAL_DIR
value: {{ .Values.virtualDir }}
{{- with .Values.extraEnv }}
{{- toYaml . | nindent 12 }}
{{- end }}
- name: LICENSE_TICKET_ID
- name: WPR_LICENSE_TICKET_ID
valueFrom:
secretKeyRef:
name: {{ include "wproofreader.fullname" . }}-lic
Expand Down
8 changes: 4 additions & 4 deletions wproofreader/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ licenseTicketID: ""
# extra environment variables to pass to the container
extraEnv: []
# extraEnv:
# - name: DOMAIN_NAME
# - name: WPR_DOMAIN_NAME
# value: "wproofreader.domain-name.com"

# directory of the service for web and API requests, e.g. http://localhost/wscservice/api?cmd=ver
Expand All @@ -25,13 +25,13 @@ virtualDir: wscservice
# note: Helm cannot reach outside its chart directory to fetch your files
# leave empty if they are already present in the container
# use same file names as those specified in Dockerfile
# (i.e. CERT_CERT_NAME and CERT_KEY_NAME variables in WProofreader official Dockerfile: https://github.com/WebSpellChecker/wproofreader-docker)
# (i.e. WPR_CERT_FILE_NAME and WPR_CERT_KEY_NAME variables in WProofreader official Dockerfile: https://github.com/WebSpellChecker/wproofreader-docker)
# otherwise, one would have to manually edit the nginx config file (/etc/nginx/conf.d/wscservice.conf) on each Pod (in each container instance)
certFile: ""
keyFile: ""
# directory where the certificate and its key will be kept inside the container
# same remark as the one above on matching the Dockerfile variables applies
# (i.e. CERT_DIR variable in WProofreader official Dockerfile: https://github.com/WebSpellChecker/wproofreader-docker)
# (i.e. WPR_CERT_DIR variable in WProofreader official Dockerfile: https://github.com/WebSpellChecker/wproofreader-docker)
certMountPath: "/certificate"

# `dictionaries` structure provide storage for custom user dictionaries inside the cluster
Expand All @@ -44,7 +44,7 @@ dictionaries:
# leave empty if no volume for custom dictionaries should be created.
localPath: ""
# location inside the container that the above directory should be mounted to
# make sure it matches DICTIONARIES_DIR variable in the Dockerfile (https://github.com/WebSpellChecker/wproofreader-docker)
# make sure it matches WPR_DICTIONARIES_DIR variable in the Dockerfile (https://github.com/WebSpellChecker/wproofreader-docker)
mountPath: "/dictionaries"
# maximum volume size – make sure it can accommodate all your data
volumeSize: "20Gi"
Expand Down