[spec] Fix memarg #1988
Merged
[spec] Fix memarg #1988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that I don’t have permission to modify this repository directly. The update now simply uses |
|
Cool, thanks! I created a PR and merged it back onto this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1986.
This fixes the type of offsets in the AST to be u64 and adds respective validation checks, refactoring memarg validity into its own auxiliary judgement.
Unfortunately, the prose generation cannot handle the new relation's shape. My attempts to teach it that were unsuccessful.
@f52985, can you please take a look and amend this PR?