Skip to content

Fix field name inconsistency #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

Fix field name inconsistency #1952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions document/core/appendix/algorithm.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,8 @@ However, these variables are not manipulated directly by the main checking funct
vals.push(type)

func pop_val() : val_type =
if (vals.size() = ctrls[0].height && ctrls[0].unreachable) return Bot
error_if(vals.size() = ctrls[0].height)
if (vals.size() = ctrls[0].val_height && ctrls[0].unreachable) return Bot
error_if(vals.size() = ctrls[0].val_height)
return vals.pop()

func pop_val(expect : val_type) : val_type =
Expand Down Expand Up @@ -268,7 +268,7 @@ The control stack is likewise manipulated through auxiliary functions:
return (if (frame.opcode = loop) frame.start_types else frame.end_types)

func unreachable() =
vals.resize(ctrls[0].height)
vals.resize(ctrls[0].val_height)
ctrls[0].unreachable := true

Pushing a control frame takes the types of the label and result values.
Expand Down