Skip to content

[spec] Fix array.new_default #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2025
Merged

[spec] Fix array.new_default #1885

merged 2 commits into from
Mar 27, 2025

Conversation

ShinWonho
Copy link
Contributor

@ShinWonho ShinWonho commented Mar 27, 2025 •
edited
Loading

Screenshot 2025-03-27 at 2 55 32 PM

I noticed that validation rule for array.new_default uses an incorrect instruction name,

Screenshot 2025-03-27 at 4 39 37 PM

and there is also a minor typo in execution rule that a parenthesis is not in the subscript.

I have corrected it.

@ShinWonho ShinWonho changed the title [spec] Wrong instruction name [spec] Fix array.new_default Mar 27, 2025
rossberg
rossberg approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rossberg rossberg merged commit 1bce50f into WebAssembly:wasm-3.0 Mar 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rossberg rossberg rossberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShinWonho @rossberg