GlobalStructInference: Run the safe parts in open world #8020
+40
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Nov 4, 2025
test/lit/passes/gsi-nontype.wast
Outdated
|
|
||
| ;; Non-type-based optimizations in --gsi | ||
| ;; RUN: foreach %s %t wasm-opt --gsi -all -S -o - | filecheck %s | ||
| ;; RUN: foreach %s %t wasm-opt --gsi --closed-world -all -S -o - | filecheck %s --check-prefix=CLOSD |
There was a problem hiding this comment.
Is all the output the same? If so, we don't need a new prefix here.
There was a problem hiding this comment.
Oh right, thanks. Removed.
mkustermann
reviewed
Nov 4, 2025
| } | ||
| addIfNoDWARFIssues("gsi"); | ||
| } | ||
| addIfNoDWARFIssues("gsi"); |
There was a problem hiding this comment.
dbc: Will this also be enabled in -Os (from the options.optimizeLevel >= 2) condition on line 749 it seems this is for -O2 and -O3)?
At least the part of gsi that will preform this global.get + struct.get optimization will lead to lower code size and would therefore make sense to run in -Os.
There was a problem hiding this comment.
Yes, this runs in -Os. -Os is equivalent to -O2 plus setting the shrink level to 1,
binaryen/src/tools/optimization-options.h
Line 46 in f23ae35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot infer a struct is only created in a global, but we can see
global.gets and optimize them, at least, in a non-type-based way,
even in open world.
Fixes #8016