Skip to content

OptimizeInstructions: Fix max bits of a local with an unreachable set #7623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

kripken
Copy link
Member

@kripken kripken commented May 27, 2025

Previously we set such locals to 64 bits, even if they were i32. This
interacted with #7505 which compared the bits to the true bits of
the type, which led to 64 != 32, which suggested we knew something
nontrivial about the bits.

Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kripken kripken merged commit 08428b3 into WebAssembly:main May 27, 2025
16 checks passed
@kripken kripken deleted the minmax.bits branch May 27, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants