Skip to content

[CI] Add a no-asserts build #7611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 19, 2025
Merged

Conversation

kripken
Copy link
Member

@kripken kripken commented May 19, 2025

All our testing has asserts enabled, to catch issues. This adds a build mode
for no-asserts, just to catch compile errors like #7610

@kripken
Copy link
Member Author

kripken commented May 19, 2025

Verified as catching that bug.

Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

@kripken kripken merged commit f11598b into WebAssembly:main May 19, 2025
16 checks passed
@kripken kripken deleted the no.asserts.test branch May 19, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants