OptimizeInstructions: Optimize x | -1 ==> -1 even with side effects (#7439)

Fixes: #7438

Author: xuruiyang2002

src/passes/OptimizeInstructions.cpp

@@ -3993,8 +3993,8 @@ struct OptimizeInstructions
       return left;
     }
     // x | -1   ==>   -1
-    if (matches(curr, binary(Or, pure(&left), ival(-1)))) {
-      return right;
+    if (matches(curr, binary(Or, any(&left), ival(-1)))) {
+      return getDroppedChildrenAndAppend(curr, right);
     }
     // (signed)x % -1   ==>   0
     if (matches(curr, binary(RemS, pure(&left), ival(-1)))) {

test/lit/passes/optimize-instructions-mvp.wast

@@ -9438,9 +9438,11 @@
   ;; CHECK-NEXT:   (i32.const -1)
   ;; CHECK-NEXT:  )
   ;; CHECK-NEXT:  (drop
-  ;; CHECK-NEXT:   (i32.or
-  ;; CHECK-NEXT:    (local.tee $x
-  ;; CHECK-NEXT:     (i32.const 1337)
+  ;; CHECK-NEXT:   (block (result i32)
+  ;; CHECK-NEXT:    (drop
+  ;; CHECK-NEXT:     (local.tee $x
+  ;; CHECK-NEXT:      (i32.const 1337)
+  ;; CHECK-NEXT:     )
   ;; CHECK-NEXT:    )
   ;; CHECK-NEXT:    (i32.const -1)
   ;; CHECK-NEXT:   )
@@ -9451,6 +9453,16 @@
   ;; CHECK-NEXT:  (drop
   ;; CHECK-NEXT:   (i64.const -1)
   ;; CHECK-NEXT:  )
+  ;; CHECK-NEXT:  (drop
+  ;; CHECK-NEXT:   (block (result i64)
+  ;; CHECK-NEXT:    (drop
+  ;; CHECK-NEXT:     (local.tee $y
+  ;; CHECK-NEXT:      (i64.const 1337)
+  ;; CHECK-NEXT:     )
+  ;; CHECK-NEXT:    )
+  ;; CHECK-NEXT:    (i64.const -1)
+  ;; CHECK-NEXT:   )
+  ;; CHECK-NEXT:  )
   ;; CHECK-NEXT: )
   (func $all_ones (param $x i32) (param $y i64)
     (drop
@@ -9485,6 +9497,14 @@
         (i64.const -1)
       )
     )
+    (drop
+      (i64.or
+        (local.tee $y
+          (i64.const 1337)
+        )
+        (i64.const -1)
+      )
+    )
   )
   ;; CHECK:      (func $xor (param $x i32) (param $y i64)
   ;; CHECK-NEXT:  (drop