OptimizeInstructions: Optimize (unsigned)x > -1 ==> i32(0) even with side effects (#7437)

Fixes: #7435

Author: xuruiyang2002

src/passes/OptimizeInstructions.cpp

@@ -4031,10 +4031,10 @@ struct OptimizeInstructions
       return getDroppedChildrenAndAppend(curr, right);
     }
     // (unsigned)x > -1   ==>   i32(0)
-    if (matches(curr, binary(GtU, pure(&left), ival(-1)))) {
+    if (matches(curr, binary(GtU, any(&left), ival(-1)))) {
       right->value = Literal::makeZero(Type::i32);
       right->type = Type::i32;
-      return right;
+      return getDroppedChildrenAndAppend(curr, right);
     }
     // (unsigned)x >= 0   ==>   i32(1)
     if (matches(curr, binary(GeU, pure(&left), ival(0)))) {

test/lit/passes/optimize-instructions-mvp.wast

@@ -11111,9 +11111,29 @@
   ;; CHECK-NEXT:   (i32.const 0)
   ;; CHECK-NEXT:  )
   ;; CHECK-NEXT:  (drop
+  ;; CHECK-NEXT:  (block (result i32)
+  ;; CHECK-NEXT:   (drop
+  ;; CHECK-NEXT:    (i32.load
+  ;; CHECK-NEXT:     (i32.const 0)
+  ;; CHECK-NEXT:    )
+  ;; CHECK-NEXT:   )
+  ;; CHECK-NEXT:   (i32.const 0)
+  ;; CHECK-NEXT:   )
+  ;; CHECK-NEXT:  )
+  ;; CHECK-NEXT:  (drop
   ;; CHECK-NEXT:   (i32.const 0)
   ;; CHECK-NEXT:  )
   ;; CHECK-NEXT:  (drop
+  ;; CHECK-NEXT:   (block (result i32)
+  ;; CHECK-NEXT:    (drop
+  ;; CHECK-NEXT:     (i64.load
+  ;; CHECK-NEXT:      (i32.const 0)
+  ;; CHECK-NEXT:     )
+  ;; CHECK-NEXT:    )
+  ;; CHECK-NEXT:    (i32.const 0)
+  ;; CHECK-NEXT:   )
+  ;; CHECK-NEXT:  )
+  ;; CHECK-NEXT:  (drop
   ;; CHECK-NEXT:   (i32.ge_s
   ;; CHECK-NEXT:    (local.get $x)
   ;; CHECK-NEXT:    (i32.const 0)
@@ -11243,10 +11263,22 @@
       (local.get $x)
       (i32.const -1)
     ))
+    (drop (i32.gt_u
+      (i32.load
+        (i32.const 0)
+      )
+      (i32.const -1)
+    ))
     (drop (i64.gt_u
       (local.get $y)
       (i64.const -1)
     ))
+    (drop (i64.gt_u
+      (i64.load
+        (i32.const 0)
+      )
+      (i64.const -1)
+    ))
     (drop (i32.gt_s
       (local.get $x)
       (i32.const -1)