Skip to content

Conversation

@cedricgarcia-wttj
Copy link
Contributor

This pull request introduces telemetry integration into the Chargebeex library, enabling users to monitor API calls via telemetry events. Key changes include modifications to the Client module to emit telemetry events for get and post requests and the addition of the :telemetry dependency in the project.

Telemetry Integration:

  • Updated the get and post methods to emit :telemetry.span events for API requests, capturing metadata such as HTTP method, URL, and status code.

Dependency Update:

  • Added the :telemetry library (~> 1.3) as a new dependency to support the telemetry integration.

@cedricgarcia-wttj cedricgarcia-wttj requested a review from a team as a code owner May 6, 2025 15:07
Chargebeex.Client.get("/customers")
```

This will emit :start and :stop telemetry events with metadata such as the HTTP method, URL, and status code, which can be processed by your telemetry handler.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add example/documentation for metadata?

@klacointe klacointe requested a review from davidjulien May 12, 2025 10:24
@klacointe klacointe merged commit a1d215c into WTTJ:master May 12, 2025
12 checks passed
@cedricgarcia-wttj cedricgarcia-wttj deleted the feat-add-telemetry-support branch May 12, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants