-
Notifications
You must be signed in to change notification settings - Fork 8
Revised and cleaned testing environment #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some tests are expected to fail as they now reveal incompatibilities (e.g. in Finally, this change also addresses the downstream issue of the |
The failing tests are due to a problem in LinearSolve which is currently being fixed, see SciML/LinearSolve.jl#591 . I think we wait for this to be merged. |
For the test environment stuff, see https://discourse.julialang.org/t/special-environment-for-testing/90306 and https://pkgdocs.julialang.org/v1/creating-packages/#adding-tests-to-packages While test/Project.toml is the newer way how to handle this, it seems that currently, the choice between [extras] and test/Project.toml appears to be seen as a matter of taste. I personally prefer the later (as you have seen...) although it also has a bit of (black) magic. In particular it was easier to add some package to the test environment via Pkg after activating it. But with 1.11, we have Pkg.add("XPkg", target=:extras), so that argument evaporated... |
We were told by Pkg folks that the latter has issues and we should prefer the |
CI is fine now. |
Is anything missing? If not, let's merge and register a new version. @Da-Be-Ru please add yourself to the authors and increase the patch version number to 1.7.1. |
But see also Da-Be-Ru#1 , could be done with this PR as well. |
I'd do the honours, but I made some last changes, so I'd rather someone approve of the final state before merging 👀 |
LGTM (looks good to me) |
Splitting the package and testing environments with separate
Project.toml
s created inconsistencies and compat problems that caused the testing environment to lag behind upstream changes to dependencies (specificallyLinearSolve
in this case).As suggested by @pjaap, I pushed the testing environment dependencies into an
[extras]
section to keep it better organized and covered in one sweep by theCompatHelper
andAqua
etc. (see related issue inExtendableFEM
).