-
Notifications
You must be signed in to change notification settings - Fork 53
Upgrade MobileUO to CUO version 0.1.8.0 #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mandlar
wants to merge
33
commits into
VoxelBoy:master
Choose a base branch
from
mandlar:tags/0.1.8.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new rendering method does not work correctly, but reverted to old method via _use_render_target flag
…builds the dll into the Unity assets folder in order to get these files working inside of Unity. The files are still symlinked to the original ones.
…rsion 0.1.15.000
…d be to CUO version 0.1.5.000
…ersion 0.1.6.0
…ersion 0.1.6.1
…t the old version of ScrollArea control into the assistant so that it would only affect the assistant and not everywhere else. The more optimal solution is to re-write the assistant with the new ScrollArea behavior
… zooming in and out
…ausing it to always split a stack of items
…e viewport window
…currently based on
…playing the same (incorrect) song everywhere in both Unity player and Android. Will re-visit later with CUO uprades
Owner
|
Wow, great work. I will run a smoke test of sorts on the branch and go over the changes to hopefully merge it in the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24
This PR is bringing CUO up to version 0.1.8.0. I fixed a number of issues and bugs that came up from migrating CUO. This build seems to be fairly stable in both Unity Player and on my Android phone. There could potentially be issues I haven't discovered yet.
// MobileUO:comment to make it easier to spot changes when upgrading from version to versionPacket.csclass ONLY for the assistant so it wouldn't be broken. In the future, it should probably be re-written to use the newPacketHandler(or whatever it is in later CUO versions).ScrollAreaUI control was re-written, I split out the old version intoAssistScrollAreaand put it inside of the assistant so it wouldn't break anything. In the future, someone should re-write the assistant to not use the oldScrollAreacontrol anymoreCUOEnvironment.Version_use_render_targettotrue, otherwise the rendering was a bit broken with the new rendering systemWorldToScreen()andMouseToWorldPosition()for cameraGetViewPort()for world renderingSetDataPointerEXT()isn't implemented in our version of XNA, so I kept old versions of using theSetData()implementation.resxfor strings) cannot be included in the main Unity project as Unity won't load them. I had to create a separate csproj to build a dll JUST for the.resxfiles in order to get Unity to read them. This solution might change slightly later in 1.x when CUO's folder structure changes.I think that sums up the highlights. At this point, I'll continue migrating CUO version by CUO version and fixing issues as they come up. Once we hit 1.x a lot of the project structure changes due to conversion to .NET Core from .NET Framework