Feat/acp hedgefund #104
Open
Feat/acp hedgefund #104
+2,979
−398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opt/gas saving
| @@ -97,10 +97,17 @@ contract ACPSimple is | |||
| address token; | |||
| uint256 amount; | |||
| address recipient; | |||
| bool isFee; | |||
| uint256 feeAmount; | |||
There was a problem hiding this comment.
Struct that is used in mapping should not be removed or moved around if it is using upgradeable contract,
Suggest to keep isFee even though it is redundant and move the feeAmount and feeType to the bottom
There was a problem hiding this comment.
the isFee field hasn't been added for production contract, so it's safe to remove
There was a problem hiding this comment.
There was a problem hiding this comment.
actually the whole PayableDetails struct hasn't been defined in mainnet contract
There was a problem hiding this comment.
noted. so when you deploy this for sepolia, it will be a new contract
There was a problem hiding this comment.
yea, it's alr deployed on sepolia as a new contract
twx-virtuals
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.