Enabled Code breakpoints and added exception filters #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedmen
commented
Sep 26, 2024
|
|
||
| context.subscriptions.push(vscode.debug.registerDebugAdapterDescriptorFactory('sqf', factory)); | ||
| if ('dispose' in factory) { | ||
| context.subscriptions.push(factory); |
There was a problem hiding this comment.
This just silences a typescript compiler error
dedmen
commented
Sep 26, 2024
| let json = JSON.parse(cmd); | ||
| json.handle = this.nextHandle(); | ||
| this.send(json); | ||
| resolve(); |
There was a problem hiding this comment.
This just silences a typescript compiler error
dedmen
commented
Sep 26, 2024
|
|
||
| private logging: boolean = false; | ||
| private verbose: boolean = false; | ||
| private getSourceFromADE: boolean = false; |
There was a problem hiding this comment.
This is now default on. Because I don't see a downside to it, it will anyway only be used if the file cannot be found locally.
Previously it was broken/disabled in ADE, but as of dedmen/ArmaDebugEngine@0495f13 that is fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code breakpoints were already supposed to be working for a long time.
They were just not listed as supported, and a Arma update broke code execution inside ADE.
Next ADE update will fix code execution, so we can also enable the condition and logging breakpoints now.
Also next ADE update gets exception filters, so you can select which kinds of script errors you want to break on.
Also enable loading code content from ADE, that was broken in ADE but fixed now.
ADE side
Exception filter: dedmen/ArmaDebugEngine@ee0a7e5
Fixing script execution: dedmen/ArmaDebugEngine@fa000c8