Skip to content

Chore/upgrade ng2 pdf viewer to v19 #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

JeevanMahesha
Copy link

@JeevanMahesha JeevanMahesha commented Apr 19, 2025

In this PR, I’ve focused on upgrading to the LTS versions of Angular and Node. Once this is merged, we can plan the migration to standalone components, signals, and the new control flow.

…werComponent

- Updated @angular/material dependency in package.json to version 17.3.10.
- Refactored PdfViewerComponent for improved readability and consistency:
  - Added missing commas in enum and class properties.
  - Reformatted constructor and method parameters for better alignment.
  - Enhanced subscription handling and event emissions.
  - Cleaned up whitespace and indentation for better code style.
…te TypeScript to 5.5.4, and enable esModuleInterop in tsconfig
- Upgraded Angular packages to version 19.x in package.json.
- Updated ng-packagr to version 19.2.2.
- Updated zone.js to version 0.15.0.

test: modify pdf-viewer component test to set standalone property

- Added standalone: false to the TestComponent in pdf-viewer.component.spec.ts.
- upgraded pdfjs-dist from 4.8.69 to ^5.1.91
- updated protractor from ~7.0.0 to ^7.0.0
- upgraded puppeteer from ^5.5.0 to ^24.6.1
- updated rxjs from ~7.8.0 to ^7.8.2
- upgraded typescript from ^5.5.4 to ^5.8.3
@JeevanMahesha JeevanMahesha marked this pull request as ready for review April 20, 2025 11:14
@shamoon
Copy link
Contributor

shamoon commented Apr 30, 2025

#1161 already exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants