-
-
Notifications
You must be signed in to change notification settings - Fork 428
Chore/upgrade ng2 pdf viewer to v19 #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JeevanMahesha
wants to merge
12
commits into
VadimDez:master
Choose a base branch
from
JeevanMahesha:chore/upgrade-ng2-pdf-viewer-to-v19
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chore/upgrade ng2 pdf viewer to v19 #1192
JeevanMahesha
wants to merge
12
commits into
VadimDez:master
from
JeevanMahesha:chore/upgrade-ng2-pdf-viewer-to-v19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…werComponent - Updated @angular/material dependency in package.json to version 17.3.10. - Refactored PdfViewerComponent for improved readability and consistency: - Added missing commas in enum and class properties. - Reformatted constructor and method parameters for better alignment. - Enhanced subscription handling and event emissions. - Cleaned up whitespace and indentation for better code style.
…te TypeScript to 5.5.4, and enable esModuleInterop in tsconfig
- Upgraded Angular packages to version 19.x in package.json. - Updated ng-packagr to version 19.2.2. - Updated zone.js to version 0.15.0. test: modify pdf-viewer component test to set standalone property - Added standalone: false to the TestComponent in pdf-viewer.component.spec.ts.
…d package-lock.json
- upgraded pdfjs-dist from 4.8.69 to ^5.1.91 - updated protractor from ~7.0.0 to ^7.0.0 - upgraded puppeteer from ^5.5.0 to ^24.6.1 - updated rxjs from ~7.8.0 to ^7.8.2 - upgraded typescript from ^5.5.4 to ^5.8.3
#1161 already exists |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I’ve focused on upgrading to the LTS versions of Angular and Node. Once this is merged, we can plan the migration to standalone components, signals, and the new control flow.