Skip to content

Rework to avoid an isinstance check #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Rework to avoid an isinstance check #2165

merged 1 commit into from
Jul 12, 2024

Conversation

adamtheturtle
Copy link
Member

No description provided.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.53%. Comparing base (e4f4f9f) to head (b316042).
Report is 2 commits behind head on main.

Files Patch % Lines
...vws/_services_validators/active_flag_validators.py 0.00% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (e4f4f9f) and HEAD (b316042). Click for more details.

HEAD has 76 uploads less than BASE
Flag BASE (e4f4f9f) HEAD (b316042)
77 1
Additional details and impacted files
@@             Coverage Diff              @@
##              main    #2165       +/-   ##
============================================
- Coverage   100.00%   56.53%   -43.47%     
============================================
  Files           74       74               
  Lines         5013     5013               
  Branches       628      628               
============================================
- Hits          5013     2834     -2179     
- Misses           0     2110     +2110     
- Partials         0       69       +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamtheturtle adamtheturtle merged commit 34fb9ac into main Jul 12, 2024
7 of 9 checks passed
@adamtheturtle adamtheturtle deleted the rm-isinstance branch July 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant