Fixing Vi{ incorrectly grabbing the ending braces #9685
Merged
+38
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whiskas101
changed the title
|
Thanks; mind adding a test case? |
|
Sure, will do. |
|
I've added a test case, let me know if im supposed to add more, or anything else I might have missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the weird behaviour when using
VisualLinemode with theVi{orVi(orVi[when the matching braces are on different lines. The issue is well explained in #9337 (relevant images explaining the problem are present there so I have omitted them here).Which issue(s) this PR fixes
As a fix for issue #9337
Special notes for your reviewer:
Only affects
VisualLinemode when usingVi{. Everything else is left untouched, all tests pass locally.