Replace QuestionIcon with DocsIcon for documentation button #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 1769455
🔗 No Linked Issue
❓ Type of change
📚 Description
Replace
QuestionIconwithDocsIconin ViewHeader component for better semantic clarity. The documentation button now displays a document icon instead of a question mark icon, which more accurately represents its purpose of linking to documentation.Changes:
docs.svgicon toapp/assets/icons/basic/ViewHeader.vueto useDocsIconcomponent instead ofQuestionIconI have been confused by this icon for a long time. Changing to a docs icon could more clearly represent the type of website it directs to. If it's a question mark, many people will think of it as a Q&A.
No conflicts and ready to merge.