Skip to content

bugfix/fix generating api when output has list union types #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

bugfix/fix generating api when output has list union types #36

merged 1 commit into from
Jan 6, 2025

Conversation

rbiseck3
Copy link
Contributor

@rbiseck3 rbiseck3 commented Jan 6, 2025 •
edited
Loading

Description

If the response type has typing data such as:

@dataclass
class Response:
  data: list[Union[int, str]]

This causes an error. This PR adds support for that.

@rbiseck3 rbiseck3 requested a review from nikpocuca January 6, 2025 20:12
nikpocuca
nikpocuca approved these changes Jan 6, 2025
View reviewed changes
Copy link

@nikpocuca nikpocuca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick mock pr, looks good to me.

@rbiseck3 rbiseck3 merged commit cd950cc into main Jan 6, 2025
7 checks passed
@rbiseck3 rbiseck3 deleted the roman/fix-list-union-response-types branch January 6, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nikpocuca nikpocuca nikpocuca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rbiseck3 @nikpocuca