Skip to content

Chore(1-3753)!: block deletion of context fields in use #10005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 19, 2025

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented May 15, 2025

Blocks deletion of context fields that are in use and updates the "active usage" count to exclude use in archived flags.

  • Before allowing you to delete a context field, checks if it is in use by any strategies. If so, returns a 409 error.
  • Updates what we count as "in use" to exclude flags that have been archived.

BREAKING CHANGE: Context fields can no longer be deleted if they are in use by active (non-archived) flags.

Copy link

vercel bot commented May 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview May 19, 2025 10:16am

Copy link
Contributor

github-actions bot commented May 15, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@thomasheartman thomasheartman force-pushed the chore(1-3753)/block-deletion-of-context-server branch from e6db55a to f26ebc8 Compare May 16, 2025 07:20
@gastonfournier gastonfournier moved this from New to In Progress in Issues and PRs May 16, 2025
@thomasheartman thomasheartman changed the title Chore(1 3753)/block deletion of context server Chore(1 3753)!: block deletion of context server May 16, 2025
@thomasheartman thomasheartman changed the title Chore(1 3753)!: block deletion of context server Chore(1 3753)!: block deletion of context fields in use May 19, 2025
@thomasheartman thomasheartman changed the title Chore(1 3753)!: block deletion of context fields in use Chore(1-3753)!: block deletion of context fields in use May 19, 2025
@thomasheartman thomasheartman marked this pull request as ready for review May 19, 2025 10:20
@coveralls
Copy link

Coverage Status

coverage: 91.228% (-0.01%) from 91.238%
when pulling 9e0a744 on chore(1-3753)/block-deletion-of-context-server
into e754212 on main.

@thomasheartman thomasheartman enabled auto-merge (squash) May 19, 2025 10:31
@thomasheartman thomasheartman disabled auto-merge May 19, 2025 10:32
@thomasheartman thomasheartman enabled auto-merge (squash) May 19, 2025 10:33
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just a minor typo

@@ -3,6 +3,7 @@ import type { FromSchema } from 'json-schema-to-ts';

export const UnleashApiErrorTypes = [
'ContentTypeError',
'ConflictErrror',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'ConflictErrror',
'ConflictError',

@thomasheartman thomasheartman merged commit 9955267 into main May 19, 2025
11 checks passed
@thomasheartman thomasheartman deleted the chore(1-3753)/block-deletion-of-context-server branch May 19, 2025 11:02
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants