Use hpp headers from geometry2 #1467
Merged
+50
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geometry2 recently changed their headers to use a .hpp instead of .h file ending. This commit adapts includes from geometry2 to that.
urfeex
force-pushed
the
migrate_cpp_headers_geometry2
branch
from
7c5b909 to
d5412f8
Compare
It happened too often recently, that things outside our upstream workspaces got changed and all pipelines were red until the breaking change was merged to main. This should help verifying these situations.
urfeex
force-pushed
the
migrate_cpp_headers_geometry2
branch
from
d5412f8 to
430c096
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
========================================
+ Coverage 3.59% 5.11% +1.52%
========================================
Files 13 33 +20
Lines 947 3404 +2457
Branches 152 427 +275
========================================
+ Hits 34 174 +140
- Misses 843 3228 +2385
+ Partials 70 2 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
URJala
approved these changes
Jul 28, 2025
|
This will break current kilted builds, as the change has not been released there, yet. See ros/rosdistro#47041. Will merge once that rosdistro PR is merged. |
|
With the compatibility layer added, this is actually mergable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geometry2 recently changed their headers to use a .hpp instead of .h file ending. This commit adapts includes from geometry2 to that.
This should fix the current rolling regression in the buildfarm, as we build the controllers with treating warnings as errors.