Skip to content

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented Jul 15, 2025

That was missed when doing the change and came up recently in #1457

That was missed when doing the change.
@urfeex urfeex requested review from a team and URJala July 15, 2025 06:37
@urfeex urfeex added documentation Improvements or additions to documentation backport-jazzy labels Jul 15, 2025
@urfeex urfeex linked an issue Jul 15, 2025 that may be closed by this pull request
1 task
@urfeex urfeex mentioned this pull request Jul 15, 2025
1 task
@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.11%. Comparing base (1b121b7) to head (fa4693c).
Report is 472 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1458      +/-   ##
========================================
+ Coverage   3.59%   5.11%   +1.52%     
========================================
  Files         13      33      +20     
  Lines        947    3404    +2457     
  Branches     152     427     +275     
========================================
+ Hits          34     174     +140     
- Misses       843    3228    +2385     
+ Partials      70       2      -68     
Flag Coverage Δ
unittests 5.11% <ø> (+1.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@URJala URJala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@urfeex
Copy link
Member Author

urfeex commented Jul 17, 2025

Will wait with merging until #1457 is resolved.

@urfeex urfeex merged commit c286e77 into UniversalRobots:main Jul 25, 2025
7 of 12 checks passed
@urfeex urfeex deleted the doc_migration_note_ros2_control_node branch July 25, 2025 10:26
mergify bot pushed a commit that referenced this pull request Jul 25, 2025
That was missed when doing the change.

(cherry picked from commit c286e77)
urfeex pushed a commit that referenced this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ur_ros2_control_node not found

2 participants