Fix flaky controller switch test #1447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were starting the tests right after we started the driver. However, the test requires that all controllers are actually available. This commit adds a check whether all required controller are actually loaded. If not all required controllers are found in a specific time, the test will throw an exception and therefore fail.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1447 +/- ##
========================================
+ Coverage 3.59% 5.11% +1.52%
========================================
Files 13 33 +20
Lines 947 3404 +2457
Branches 152 427 +275
========================================
+ Hits 34 174 +140
- Misses 843 3228 +2385
+ Partials 70 2 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
urmahp
approved these changes
Jul 8, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
We were starting the tests right after we started the driver. However, the test requires that all controllers are actually available. This commit adds a check whether all required controllers are actually loaded. If not all required controllers are found in a specific time, the test will throw an exception and therefore fail. (cherry picked from commit d675a36)
mergify bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
We were starting the tests right after we started the driver. However, the test requires that all controllers are actually available. This commit adds a check whether all required controllers are actually loaded. If not all required controllers are found in a specific time, the test will throw an exception and therefore fail. (cherry picked from commit d675a36)
This was referenced Jul 8, 2025
urfeex
pushed a commit
that referenced
this pull request
Jul 8, 2025
We were starting the tests right after we started the driver. However, the test requires that all controllers are actually available. This commit adds a check whether all required controllers are actually loaded. If not all required controllers are found in a specific time, the test will throw an exception and therefore fail.
urfeex
pushed a commit
that referenced
this pull request
Jul 8, 2025
We were starting the tests right after we started the driver. However, the test requires that all controllers are actually available. This commit adds a check whether all required controllers are actually loaded. If not all required controllers are found in a specific time, the test will throw an exception and therefore fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were starting the tests right after we started the driver. However, the test requires that all controllers are actually available. This commit adds a check whether all required controller are actually loaded.
If not all required controllers are found in a specific time, the test will throw an exception and therefore fail.
This should fix failures such as https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/actions/runs/16107576360/job/45452852404