-
Couldn't load subscription status.
- Fork 300
Added 'is in remote control' call as a dashboard service #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
========================================
+ Coverage 3.59% 5.11% +1.52%
========================================
Files 13 33 +20
Lines 947 3404 +2457
Branches 152 427 +275
========================================
+ Hits 34 174 +140
- Misses 843 3228 +2385
+ Partials 70 2 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works, but please add documentation to https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/blob/main/ur_robot_driver/doc/dashboard_client.rst
|
I have added documentation, but the link I provided for the service doesn't exist yet as a new service type has been created. |
(cherry picked from commit 868f240)
(cherry picked from commit 868f240) # Conflicts: # ur_robot_driver/doc/dashboard_client.rst
This will fix #1195