Skip to content

Conversation

@urmahp
Copy link
Contributor

@urmahp urmahp commented Jun 26, 2025

This will fix #1195

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 5.11%. Comparing base (1b121b7) to head (5282740).
Report is 466 commits behind head on main.

Files with missing lines Patch % Lines
ur_robot_driver/src/dashboard_client_ros.cpp 0.00% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1433      +/-   ##
========================================
+ Coverage   3.59%   5.11%   +1.52%     
========================================
  Files         13      33      +20     
  Lines        947    3404    +2457     
  Branches     152     427     +275     
========================================
+ Hits          34     174     +140     
- Misses       843    3228    +2385     
+ Partials      70       2      -68     
Flag Coverage Δ
unittests 5.11% <0.00%> (+1.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@urmahp
Copy link
Contributor Author

urmahp commented Jun 26, 2025

I have added documentation, but the link I provided for the service doesn't exist yet as a new service type has been created.
4aa5964#diff-2ef7b991fcda5a9e699b32003462d05fefb9ac4fa1166ffc0093430d77b2c580R136

@urfeex urfeex merged commit 868f240 into UniversalRobots:main Jun 26, 2025
6 of 12 checks passed
mergify bot pushed a commit that referenced this pull request Jun 26, 2025
mergify bot pushed a commit that referenced this pull request Jun 26, 2025
(cherry picked from commit 868f240)

# Conflicts:
#	ur_robot_driver/doc/dashboard_client.rst
@urmahp urmahp deleted the add_remote_control_srv branch June 26, 2025 10:49
urfeex pushed a commit that referenced this pull request Jun 26, 2025
…1433) (#1436)

Co-authored-by: Mads Holm Peters <79145214+urmahp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "is in remote control" call as a dashboard service

2 participants