ur_calibration: Fix compilation with BUILD_SHARED_LIBS:BOOL=ON on Windows #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urfeex
approved these changes
Jun 13, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
(cherry picked from commit 9dae45a)
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
(cherry picked from commit 9dae45a)
urfeex
pushed a commit
that referenced
this pull request
Jun 17, 2025
urfeex
pushed a commit
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package compiles a library, but does not expose any symbol on Windows, so if the CMake project is compiled with
-DBUILD_SHARED_LIBS:BOOL=ONon Windows, no library is actually generated.On Linux and macOS, everything compiles fine with
-DBUILD_SHARED_LIBS:BOOL=ONas by default all the symbols are visible. We can achieve exactly the same behavior in Windows by setting toONtheCMAKE_WINDOWS_EXPORT_ALL_SYMBOLSCMake variable, so this PR sets theCMAKE_WINDOWS_EXPORT_ALL_SYMBOLSvariable toON, to ensure that the compilation with-DBUILD_SHARED_LIBS:BOOL=ONworks fine on Windows.Furthermore, the
-Wno-unused-parameteris a GCC/Clang specific compilations option, so I moved it in the existingiffor adding GCC/Clang specific compilations options.