Skip to content

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented Jun 10, 2025

Since there are still outstanding upstream problems, let's try to fix them for our CI so we don't have to fly blind anymore.

@urfeex
Copy link
Member Author

urfeex commented Jun 10, 2025

Since moveit_resources was just released, this will probably not be necessary anymore.

@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.06%. Comparing base (1b121b7) to head (2f87bd1).
Report is 460 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1394      +/-   ##
========================================
+ Coverage   3.59%   5.06%   +1.47%     
========================================
  Files         13      33      +20     
  Lines        947    3437    +2490     
  Branches     152     424     +272     
========================================
+ Hits          34     174     +140     
- Misses       843    3261    +2418     
+ Partials      70       2      -68     
Flag Coverage Δ
unittests 5.06% <ø> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Since installing packages from there is required for moveit-servo, let's
add it to the upstream workspace.
@urfeex urfeex force-pushed the fix_semi_binary_builds branch from 5b55529 to 2f87bd1 Compare June 17, 2025 06:45
@urfeex urfeex marked this pull request as ready for review June 17, 2025 06:50
@urfeex urfeex requested a review from a team June 17, 2025 06:50
@urfeex
Copy link
Member Author

urfeex commented Jun 17, 2025

Let's add it. We don't know when the next rolling sync will be and until then we will not have a working semi-binary unless we merge this.

@urfeex urfeex added the CI label Jun 17, 2025
@urfeex urfeex merged commit 2e651da into UniversalRobots:main Jun 17, 2025
8 of 12 checks passed
@urfeex urfeex deleted the fix_semi_binary_builds branch June 17, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants