Ignore deprecation warning for set_gains for now #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream API isn't finalized, yet. For now, let's ignore the deprecation warning in order to not fail our builds.
urmahp
approved these changes
Jun 11, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
The upstream API isn't finalized, yet. For now, let's ignore the deprecation warning in order to not fail our builds. (cherry picked from commit 51da629)
urfeex
pushed a commit
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream API isn't finalized, yet. For now, let's ignore the deprecation warning in order to not fail our builds.
As discussed in ros-controls/control_toolbox#392 the API change isn't final, yet.