[force mode controller] Fix the task frame orientation #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we were using a RPY notation. Chaning that to an angle-axis notation should fix things.
…one of the main axes
urfeex
force-pushed
the
fix_force_controller_direction
branch
from
3c8223c to
638ab3f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1379 +/- ##
========================================
+ Coverage 3.59% 5.06% +1.47%
========================================
Files 13 33 +20
Lines 947 3438 +2491
Branches 152 424 +272
========================================
+ Hits 34 174 +140
- Misses 843 3262 +2419
+ Partials 70 2 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This should avoid a coincitental overlap if the transformation is wrong.
urfeex
force-pushed
the
fix_force_controller_direction
branch
from
638ab3f to
81a2282
Compare
urmahp
approved these changes
May 28, 2025
mergify bot
pushed a commit
that referenced
this pull request
May 28, 2025
* [force mode controller] Fix the task frame orientation Before, we were using a RPY notation. Chaning that to an angle-axis notation should fix things. * Update force_mode example to include a pose that is not in line with one of the main axes * Make test use an arbitraty orientation This should avoid a coincitental overlap if the transformation is wrong. (cherry picked from commit 8eb4288) # Conflicts: # ur_robot_driver/test/integration_test_force_mode.py
|
@Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 28, 2025
* [force mode controller] Fix the task frame orientation Before, we were using a RPY notation. Chaning that to an angle-axis notation should fix things. * Update force_mode example to include a pose that is not in line with one of the main axes * Make test use an arbitraty orientation This should avoid a coincitental overlap if the transformation is wrong. (cherry picked from commit 8eb4288)
urfeex
pushed a commit
that referenced
this pull request
May 28, 2025
…1379) (#1381) * [force mode controller] Fix the task frame orientation Before, we were using a RPY notation. Chaning that to an angle-axis notation should fix things. * Update force_mode example to include a pose that is not in line with one of the main axes * Make test use an arbitraty orientation This should avoid a coincitental overlap if the transformation is wrong.
urfeex
added a commit
that referenced
this pull request
Jun 2, 2025
Before, we were using a RPY notation. Chaning that to an angle-axis notation should fix things. * Update force_mode example to include a pose that is not in line with one of the main axes * Make test use an arbitraty orientation This should avoid a coincitental overlap if the transformation is wrong. (cherry picked from commit 8eb4288) # Conflicts: # ur_robot_driver/test/integration_test_force_mode.py
urfeex
added a commit
that referenced
this pull request
Jun 2, 2025
… (#1380) Before, we were using a RPY notation. Chaning that to an angle-axis notation should fix things. * Update force_mode example to include a pose that is not in line with one of the main axes * Make test use an arbitraty orientation This should avoid a coincitental overlap if the transformation is wrong. (cherry picked from commit 8eb4288) # Conflicts: # ur_robot_driver/test/integration_test_force_mode.py * [force mode controller] Fix the task frame orientation (#1379) Before, we were using a RPY notation. Chaning that to an angle-axis notation should fix things. * Update force_mode example to include a pose that is not in line with one of the main axes * Make test use an arbitraty orientation This should avoid a coincitental overlap if the transformation is wrong. (cherry picked from commit 8eb4288) # Conflicts: # ur_robot_driver/test/integration_test_force_mode.py --------- Co-authored-by: Felix Exner <feex@universal-robots.com>
u-decs
pushed a commit
to u-decs/Universal_Robots_ROS2_Driver
that referenced
this pull request
Jun 17, 2025
…ersalRobots#1379) (UniversalRobots#1380) Before, we were using a RPY notation. Chaning that to an angle-axis notation should fix things. * Update force_mode example to include a pose that is not in line with one of the main axes * Make test use an arbitraty orientation This should avoid a coincitental overlap if the transformation is wrong. (cherry picked from commit 8eb4288) # Conflicts: # ur_robot_driver/test/integration_test_force_mode.py * [force mode controller] Fix the task frame orientation (UniversalRobots#1379) Before, we were using a RPY notation. Chaning that to an angle-axis notation should fix things. * Update force_mode example to include a pose that is not in line with one of the main axes * Make test use an arbitraty orientation This should avoid a coincitental overlap if the transformation is wrong. (cherry picked from commit 8eb4288) # Conflicts: # ur_robot_driver/test/integration_test_force_mode.py --------- Co-authored-by: Felix Exner <feex@universal-robots.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we were using a RPY notation. Changing that to an angle-axis notation should fix things.
This should fix #1375
@bsolon-tri would you like to try that locally?
I want to add a test checking further orientations and an updated example before merging this, but testing things locally seem to have resolved the issue.