Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented May 14, 2025

Recently, our check_links workflow was failing very often, apparently GitHub has introduced new rate limits. I played around with lychee, a tool specifically made for link checking, which supports caching and even understands local links in Markdown and RST files.

It is significantly faster and allows caching built-in. And it helped me find three dead (local) links in the robot_driver's README.

Note: I expect things to fail with the initial run, as the cache has to be built up first.


This is an automatic backport of pull request #1355 done by Mergify.

@mergify
Copy link
Author

mergify bot commented May 14, 2025

Cherry-pick of d38be8e has failed:

On branch mergify/bp/humble/pr-1355
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit d38be8e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	deleted:    .github/helpers/check_urls.sh
	modified:   .gitignore

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/check_links.yml
	both modified:   ur_robot_driver/README.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added conflicts humble Relevant for humble and higher ROS versions labels May 14, 2025
@urfeex urfeex force-pushed the mergify/bp/humble/pr-1355 branch from bce9cb3 to 8d5ab5f Compare May 15, 2025 09:59
@urfeex urfeex removed the conflicts label May 15, 2025
@urfeex urfeex merged commit 5dfed5d into humble May 15, 2025
7 checks passed
@urfeex urfeex deleted the mergify/bp/humble/pr-1355 branch May 15, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

humble Relevant for humble and higher ROS versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant