Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Apr 7, 2025

When transferring trajectories with many waypoints it can take quite a
while until all points are transferred from the controller to the
hardware interface, especially on lower hardware_interface update rates.

With this change, execution starts as soon as enough trajectory points
are transferred to fill 5 control cycles.

This PR effectively allows reducing the hardware_interface update_rate
when using the passthrough_trajectory_controller significantly. This
will reduce the networking requirements improving the overall user
experience.


This is an automatic backport of pull request #1313 done by Mergify.

@mergify mergify bot added conflicts humble Relevant for humble and higher ROS versions labels Apr 7, 2025
@mergify
Copy link
Author

mergify bot commented Apr 7, 2025

Cherry-pick of 14f80ac has failed:

On branch mergify/bp/humble/pr-1313
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 14f80ac.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ur_controllers/include/ur_controllers/passthrough_trajectory_controller.hpp
	modified:   ur_robot_driver/include/ur_robot_driver/hardware_interface.hpp
	modified:   ur_robot_driver/src/hardware_interface.cpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   ur_controllers/src/passthrough_trajectory_controller.cpp
	deleted by us:   ur_robot_driver/urdf/ur.ros2_control.xacro

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

…transferred. (#1313)

* Start executing passthrough trajectories earlier than all points are transferred.

When transferring trajectories with many waypoints it can take quite a
while until all points are transferred from the controller to the
hardware interface, especially on lower hardware_interface update rates.

With this change, execution starts as soon as enough trajectory points
are transferred to fill 5 control cycles.

This PR effectively allows reducing the hardware_interface update_rate
when using the passthrough_trajectory_controller significantly. This
will reduce the networking requirements improving the overall user
experience.

* Make sure we acknowledge a new trajectory before sending points

If we miss the new trajectory, wen cannot resize the vectors
appropriately.
@urfeex urfeex force-pushed the mergify/bp/humble/pr-1313 branch from dba3fb2 to de42279 Compare April 7, 2025 07:45
@urfeex urfeex removed the conflicts label Apr 7, 2025
@urfeex urfeex merged commit 72c0b03 into humble Apr 7, 2025
6 of 7 checks passed
@urfeex urfeex deleted the mergify/bp/humble/pr-1313 branch April 7, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

humble Relevant for humble and higher ROS versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant