Skip to content

Conversation

@fmauch
Copy link
Contributor

@fmauch fmauch commented Oct 9, 2024

Update broken links from README and add a URL checker to CI.

Felix Exner added 2 commits October 9, 2024 13:31
This way we should find our earlier if a link breaks.
@fmauch fmauch added the documentation Improvements or additions to documentation label Oct 9, 2024
@fmauch fmauch requested a review from VinDp October 9, 2024 12:06
Copy link
Contributor

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed the broken links today, apparently I was not quick enough in making an issue! Besides that, looks good and seems to work!

@fmauch
Copy link
Contributor Author

fmauch commented Oct 9, 2024

No, it doesn't work yet. Please do not merge yet

@fmauch fmauch changed the title Readme update hosted docs WIP: Readme update hosted docs Oct 9, 2024
@VinDp
Copy link
Contributor

VinDp commented Oct 9, 2024

Yep, I noticed after approving

@fmauch
Copy link
Contributor Author

fmauch commented Oct 9, 2024

@VinDp now it is working as expected.

@fmauch fmauch changed the title WIP: Readme update hosted docs Readme update hosted docs Oct 9, 2024
@fmauch fmauch requested a review from VinDp October 10, 2024 09:24
Copy link
Contributor

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@VinDp VinDp merged commit ff3ce21 into main Oct 10, 2024
7 of 12 checks passed
@VinDp VinDp deleted the readme_update_hosted_docs branch October 10, 2024 09:55
URJala pushed a commit to URJala/Universal_Robots_ROS2_Driver that referenced this pull request Dec 20, 2024
* Update doc links from README to use separate doc

* Add a URL check to CI

This way we should find our earlier if a link breaks.

* Update link check to have ignore patterns

* Fix array handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants