Skip to content

fix: Extended UniversalRpcTests run times #3560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 26, 2025
+620 −91
Merged

fix: Extended UniversalRpcTests run times #3560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dbe83c7
update
NoelStephensUnity Jul 23, 2025
364e058
test - refactor
NoelStephensUnity Jul 24, 2025
8f2a3a0
style & update
NoelStephensUnity Jul 24, 2025
29eb297
test - update
NoelStephensUnity Jul 25, 2025
ad0dd0f
test - update
NoelStephensUnity Jul 25, 2025
a437cde
test - fix
NoelStephensUnity Jul 25, 2025
b08ed90
test - fix & refactor
NoelStephensUnity Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion com.unity.netcode.gameobjects/Tests/Editor/Messaging/MessageCorruptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ public unsafe void Send(ulong clientId, NetworkDelivery delivery, FastBufferWrit
for (int i = 0; i < 4; i++)
{
var currentByte = batchData.GetUnsafePtr()[i];
batchData.WriteByteSafe((byte)(currentByte == 0 ? 1 : 0));
currentByte = (byte)((currentByte + 1) % 255);
batchData.WriteByteSafe(currentByte);
MessageQueue.Add(batchData.ToArray());
}
break;
Expand Down
5 changes: 4 additions & 1 deletion com.unity.netcode.gameobjects/Tests/Runtime/Transports/UnityTransportTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public IEnumerator Cleanup()

// Need to destroy the GameObject (all assigned components will get destroyed too)
UnityEngine.Object.DestroyImmediate(m_Server.gameObject);
m_Server = null;
}

if (m_Client1)
Expand All @@ -51,6 +52,7 @@ public IEnumerator Cleanup()

// Need to destroy the GameObject (all assigned components will get destroyed too)
UnityEngine.Object.DestroyImmediate(m_Client1.gameObject);
m_Client1 = null;
}

if (m_Client2)
Expand All @@ -59,6 +61,7 @@ public IEnumerator Cleanup()

// Need to destroy the GameObject (all assigned components will get destroyed too)
UnityEngine.Object.DestroyImmediate(m_Client2.gameObject);
m_Client2 = null;
}

m_ServerEvents?.Clear();
Expand Down Expand Up @@ -315,7 +318,7 @@ public IEnumerator DisconnectOnReliableSendQueueOverflow()
m_Server.StartServer();
m_Client1.StartClient();

yield return WaitForNetworkEvent(NetworkEvent.Connect, m_Client1Events);
yield return WaitForNetworkEvent(NetworkEvent.Connect, m_Client1Events, 5.0f);

m_Server.Shutdown();

Expand Down
Loading