Skip to content

fix: NetworkBehaviour and NetworkVariableDelta length safety checks #3405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: develop-2.0.0
Choose a base branch
from
Open

fix: NetworkBehaviour and NetworkVariableDelta length safety checks #3405

wants to merge 7 commits into from

Conversation

EmandM
Copy link
Collaborator

@EmandM EmandM commented Apr 14, 2025 •
edited
Loading

MTTB-1080

fixes: #3335

Changelog

  • Fixed: NetworkBehaviour length safety checks use int instead of ushort
  • Fixed: NetworkVariable EnsureNetworkVariableLengthSafety checks use int instead of ushort
  • Fixed: NetworkVariableDeltas did not work with DistributedAuthorityMode and EnsureNetworkVariableLengthSafety

Testing and Documentation

  • Includes unit tests.
  • No documentation changes or additions were necessary.

Backport

Backported in #3415

@EmandM EmandM requested a review from a team as a code owner April 14, 2025 22:52
NoelStephensUnity
NoelStephensUnity approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
:godmode:

NoelStephensUnity
NoelStephensUnity requested changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be unblocked by MTT-11938 and MTTB-1222.

@EmandM EmandM mentioned this pull request Apr 18, 2025
Merged
NoelStephensUnity pushed a commit that referenced this pull request Apr 25, 2025
@EmandM @michalChrobot
fix: [Backport] NetworkBehaviour and NetworkVariable length safety ch…
9687c8a 
…ecks (#3415)

<!-- Replace this block with what this PR does and why. Describe what
you'd like reviewers to know, how you applied the engineering
principles, and any interesting tradeoffs made. Delete bullet points
below that don't apply, and update the changelog section as appropriate.
-->

<!-- Add short version of the JIRA ticket to the PR title (e.g. "feat:
new shiny feature [MTT-123]") -->
[MTTB-1080](https://jira.unity3d.com/browse/MTTB-1080)

1.x for #3335 

## Changelog

- Fixed: NetworkBehaviour length safety checks use `int` instead of
`ushort`
- Fixed: NetworkVariable `EnsureNetworkVariableLengthSafety` checks use
`int` instead of `ushort`

## Testing and Documentation

- No tests have been added.

<!-- Uncomment and mark items off with a * if this PR deprecates any
API:
### Deprecated API
- [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter
yyyy-mm-dd)` entry.
- [ ] An [api updater] was added.
- [ ] Deprecation of the API is explained in the CHANGELOG.
- [ ] The users can understand why this API was removed and what they
should use instead.
-->

## Backport

<!-- If this is a backport:
 - Add the following to the PR title: "\[Backport\] ..." .
 - Link to the original PR.
If this needs a backport - state this here
If a backport is not needed please provide the reason why.
If the "Backports" section is not present it will lead to a CI test
failure.
-->

This is a backport of #3405

---------

Co-authored-by: Michał Chrobot <124174716+michalChrobot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmandM @NoelStephensUnity