docs: [1.X] fixes of PVP exceptions (round 2)

com.unity.netcode.gameobjects/Runtime/Configuration/NetworkConfig.cs

@@ -31,6 +31,9 @@ public class NetworkConfig
         [Tooltip("When set, NetworkManager will automatically create and spawn the assigned player prefab. This can be overridden by adding it to the NetworkPrefabs list and selecting override.")]
         public GameObject PlayerPrefab;
 
+        /// <summary>
+        /// The collection of network prefabs available for spawning across the network
+        /// </summary>
         [SerializeField]
         public NetworkPrefabs Prefabs = new NetworkPrefabs();
 

com.unity.netcode.gameobjects/Runtime/Configuration/NetworkPrefab.cs

@@ -57,6 +57,11 @@ public class NetworkPrefab
         /// </summary>
         public GameObject OverridingTargetPrefab;
 
+        /// <summary>
+        /// Compares this NetworkPrefab with another to determine equality
+        /// </summary>
+        /// <param name="other">The NetworkPrefab to compare against</param>
+        /// <returns>True if all fields match between the two NetworkPrefabs, false otherwise</returns>
         public bool Equals(NetworkPrefab other)
         {
             return Override == other.Override &&
@@ -66,6 +71,12 @@ public bool Equals(NetworkPrefab other)
                    OverridingTargetPrefab == other.OverridingTargetPrefab;
         }
 
+        /// <summary>
+        /// Gets the GlobalObjectIdHash of the source prefab based on the current override settings
+        /// </summary>
+        /// <value>The hash value identifying the source prefab</value>
+        /// <exception cref="InvalidOperationException">Thrown when required prefab references are missing or invalid</exception>
+        /// <exception cref="ArgumentOutOfRangeException">Thrown when Override has an invalid value</exception>
         public uint SourcePrefabGlobalObjectIdHash
         {
             get
@@ -98,6 +109,12 @@ public uint SourcePrefabGlobalObjectIdHash
             }
         }
 
+        /// <summary>
+        /// Gets the GlobalObjectIdHash of the target prefab when using prefab overrides
+        /// </summary>
+        /// <value>The hash value identifying the target prefab, or 0 if no override is set</value>
+        /// <exception cref="InvalidOperationException">Thrown when required prefab references are missing or invalid</exception>
+        /// <exception cref="ArgumentOutOfRangeException">Thrown when Override has an invalid value</exception>
         public uint TargetPrefabGlobalObjectIdHash
         {
             get
@@ -122,6 +139,11 @@ public uint TargetPrefabGlobalObjectIdHash
             }
         }
 
+        /// <summary>
+        /// Validates the NetworkPrefab configuration to ensure all required fields are properly set
+        /// </summary>
+        /// <param name="index">Optional index used for error reporting when validating lists of prefabs</param>
+        /// <returns>True if the NetworkPrefab is valid and ready for use, false otherwise</returns>
         public bool Validate(int index = -1)
         {
             NetworkObject networkObject;
@@ -224,6 +246,10 @@ public bool Validate(int index = -1)
             return true;
         }
 
+        /// <summary>
+        /// Returns a string representation of this NetworkPrefab's source and target hash values
+        /// </summary>
+        /// <returns>A string containing the source and target hash values</returns>
         public override string ToString()
         {
             return $"{{SourceHash: {SourceHashToOverride}, TargetHash: {TargetPrefabGlobalObjectIdHash}}}";

com.unity.netcode.gameobjects/Runtime/Configuration/NetworkPrefabs.cs

@@ -39,6 +39,9 @@ public class NetworkPrefabs
         [NonSerialized]
         public Dictionary<uint, uint> OverrideToNetworkPrefab = new Dictionary<uint, uint>();
 
+        /// <summary>
+        /// Gets the read-only list of all registered network prefabs
+        /// </summary>
         public IReadOnlyList<NetworkPrefab> Prefabs => m_Prefabs;
 
         [NonSerialized]
@@ -62,6 +65,9 @@ private void RemoveTriggeredByNetworkPrefabList(NetworkPrefab networkPrefab)
             m_Prefabs.Remove(networkPrefab);
         }
 
+        /// <summary>
+        /// Finalizer that ensures proper cleanup of network prefab resources
+        /// </summary>
         ~NetworkPrefabs()
         {
             Shutdown();
@@ -84,6 +90,7 @@ internal void Shutdown()
         /// Processes the <see cref="NetworkPrefabsList"/> if one is present for use during runtime execution,
         /// else processes <see cref="Prefabs"/>.
         /// </summary>
+        /// <param name="warnInvalid">When true, logs warnings about invalid prefabs that are removed during initialization</param>
         public void Initialize(bool warnInvalid = true)
         {
             m_Prefabs.Clear();
@@ -156,6 +163,8 @@ public void Initialize(bool warnInvalid = true)
         /// <summary>
         /// Add a new NetworkPrefab instance to the list
         /// </summary>
+        /// <param name="networkPrefab">The NetworkPrefab to add</param>
+        /// <returns>True if the prefab was successfully added, false if it was invalid or already registered</returns>
         /// <remarks>
         /// The framework does not synchronize this list between clients. Any runtime changes must be handled manually.
         ///
@@ -177,6 +186,7 @@ public bool Add(NetworkPrefab networkPrefab)
         /// <summary>
         /// Remove a NetworkPrefab instance from the list
         /// </summary>
+        /// <param name="prefab">The NetworkPrefab to remove</param>
         /// <remarks>
         /// The framework does not synchronize this list between clients. Any runtime changes must be handled manually.
         ///
@@ -199,6 +209,7 @@ public void Remove(NetworkPrefab prefab)
         /// <summary>
         /// Remove a NetworkPrefab instance with matching <see cref="NetworkPrefab.Prefab"/> from the list
         /// </summary>
+        /// <param name="prefab">The GameObject to match against for removal</param>
         /// <remarks>
         /// The framework does not synchronize this list between clients. Any runtime changes must be handled manually.
         ///

com.unity.netcode.gameobjects/Runtime/Connection/NetworkConnectionManager.cs

@@ -11,7 +11,7 @@
 namespace Unity.Netcode
 {
     /// <summary>
-    /// The connection event type set within <see cref="ConnectionEventData"/> to signify the type of connection event notification received.   
+    /// The connection event type set within <see cref="ConnectionEventData"/> to signify the type of connection event notification received.
     /// </summary>
     /// <remarks>
     /// <see cref="ConnectionEventData"/> is returned as a parameter of the <see cref="NetworkManager.OnConnectionEvent"/> event notification.
@@ -60,6 +60,9 @@ public enum ConnectionEvent
     /// </remarks>
     public struct ConnectionEventData
     {
+        /// <summary>
+        /// The type of connection event that occurred
+        /// </summary>
         public ConnectionEvent EventType;
 
         /// <summary>

com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviour.cs

@@ -6,8 +6,15 @@
 
 namespace Unity.Netcode
 {
+    /// <summary>
+    /// Exception thrown when an RPC (Remote Procedure Call) encounters an error during execution
+    /// </summary>
     public class RpcException : Exception
     {
+        /// <summary>
+        /// Initializes a new instance of the RpcException class with a specified error message
+        /// </summary>
+        /// <param name="message">The message that describes the error</param>
         public RpcException(string message) : base(message)
         {
 

com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs

@@ -44,6 +44,10 @@ public class NetworkManager : MonoBehaviour, INetworkUpdateSystem
 
 #pragma warning restore IDE1006 // restore naming rule violation check
 
+        /// <summary>
+        /// Processes network-related updates for a specific update stage in the frame
+        /// </summary>
+        /// <param name="updateStage">The current network update stage being processed</param>
         public void NetworkUpdate(NetworkUpdateStage updateStage)
         {
             switch (updateStage)
@@ -294,6 +298,10 @@ public event Action OnTransportFailure
             remove => ConnectionManager.OnTransportFailure -= value;
         }
 
+        /// <summary>
+        /// Delegate for handling network state reanticipation events
+        /// </summary>
+        /// <param name="lastRoundTripTime">The most recent round-trip time measurement in seconds between client and server</param>
         public delegate void ReanticipateDelegate(double lastRoundTripTime);
 
         /// <summary>

com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

@@ -388,6 +388,7 @@ private GlobalObjectId GetGlobalId()
         /// Delegate type for checking visibility
         /// </summary>
         /// <param name="clientId">The clientId to check visibility for</param>
+        /// <returns>True if the object should be visible to the specified client, false otherwise</returns>
         public delegate bool VisibilityDelegate(ulong clientId);
 
         /// <summary>
@@ -399,6 +400,7 @@ private GlobalObjectId GetGlobalId()
         /// Delegate type for checking spawn options
         /// </summary>
         /// <param name="clientId">The clientId to check spawn options for</param>
+        /// <returns>True if the object should be spawned for the specified client, false otherwise</returns>
         public delegate bool SpawnDelegate(ulong clientId);
 
         /// <summary>
@@ -1565,6 +1567,11 @@ internal ushort GetNetworkBehaviourOrderIndex(NetworkBehaviour instance)
             return 0;
         }
 
+        /// <summary>
+        /// Gets a NetworkBehaviour component at the specified index in this object's NetworkBehaviour list
+        /// </summary>
+        /// <param name="index">The zero-based index of the NetworkBehaviour to retrieve</param>
+        /// <returns>The NetworkBehaviour at the specified index, or null if the index is out of bounds</returns>
         public NetworkBehaviour GetNetworkBehaviourAtOrderIndex(ushort index)
         {
             if (index >= ChildNetworkBehaviours.Count)

com.unity.netcode.gameobjects/Runtime/Messaging/CustomMessageManager.cs

@@ -139,6 +139,8 @@ public void SendUnnamedMessage(ulong clientId, FastBufferWriter messageBuffer, N
         /// <summary>
         /// Delegate used to handle named messages
         /// </summary>
+        /// <param name="senderClientId">The client identifier of the message sender</param>
+        /// <param name="messagePayload">The buffer containing the message data to be read</param>
         public delegate void HandleNamedMessageDelegate(ulong senderClientId, FastBufferReader messagePayload);
 
         private Dictionary<ulong, HandleNamedMessageDelegate> m_NamedMessageHandlers32 = new Dictionary<ulong, HandleNamedMessageDelegate>();

com.unity.netcode.gameobjects/Runtime/Messaging/GenerateSerializationForGenericParameterAttribute.cs

@@ -74,6 +74,10 @@ public class GenerateSerializationForGenericParameterAttribute : Attribute
     {
         internal int ParameterIndex;
 
+        /// <summary>
+        /// Initializes a new instance of the attribute
+        /// </summary>
+        /// <param name="parameterIndex">The zero-based index of the generic parameter that should be serialized</param>
         public GenerateSerializationForGenericParameterAttribute(int parameterIndex)
         {
             ParameterIndex = parameterIndex;

com.unity.netcode.gameobjects/Runtime/Messaging/GenerateSerializationForTypeAttribute.cs

@@ -18,6 +18,10 @@ public class GenerateSerializationForTypeAttribute : Attribute
     {
         internal Type Type;
 
+        /// <summary>
+        /// Initializes a new instance of the attribute
+        /// </summary>
+        /// <param name="type">The type that should have serialization code generated for it</param>
         public GenerateSerializationForTypeAttribute(Type type)
         {
             Type = type;

com.unity.netcode.gameobjects/Runtime/Messaging/RpcAttributes.cs

@@ -25,11 +25,29 @@ public enum RpcDelivery
     public class RpcAttribute : Attribute
     {
         // Must match the set of parameters below
+        /// <summary>
+        /// Parameters that define the behavior of an RPC
+        /// </summary>
         public struct RpcAttributeParams
         {
+            /// <summary>
+            /// The delivery method for the RPC
+            /// </summary>
             public RpcDelivery Delivery;
+
+            /// <summary>
+            /// When true, only the owner of the object can execute this RPC
+            /// </summary>
             public bool RequireOwnership;
+
+            /// <summary>
+            /// When true, local execution of the RPC is deferred until the next network tick
+            /// </summary>
             public bool DeferLocal;
+
+            /// <summary>
+            /// When true, allows the RPC target to be overridden at runtime
+            /// </summary>
             public bool AllowTargetOverride;
         }
 
@@ -38,10 +56,26 @@ public struct RpcAttributeParams
         /// Type of RPC delivery method
         /// </summary>
         public RpcDelivery Delivery = RpcDelivery.Reliable;
+
+        /// <summary>
+        /// When true, only the owner of the object can execute this RPC
+        /// </summary>
         public bool RequireOwnership;
+
+        /// <summary>
+        /// When true, local execution of the RPC is deferred until the next network tick
+        /// </summary>
         public bool DeferLocal;
+
+        /// <summary>
+        /// When true, allows the RPC target to be overridden at runtime
+        /// </summary>
         public bool AllowTargetOverride;
 
+        /// <summary>
+        /// Initializes a new instance of the RpcAttribute with the specified target
+        /// </summary>
+        /// <param name="target">The target for this RPC</param>
         public RpcAttribute(SendTo target)
         {
         }
@@ -60,8 +94,14 @@ private RpcAttribute()
     [AttributeUsage(AttributeTargets.Method)]
     public class ServerRpcAttribute : RpcAttribute
     {
+        /// <summary>
+        /// When true, only the owner of the NetworkObject can invoke this ServerRpc
+        /// </summary>
         public new bool RequireOwnership;
 
+        /// <summary>
+        /// Initializes a new instance of ServerRpcAttribute configured to target the server
+        /// </summary>
         public ServerRpcAttribute() : base(SendTo.Server)
         {
 
@@ -75,6 +115,9 @@ public ServerRpcAttribute() : base(SendTo.Server)
     [AttributeUsage(AttributeTargets.Method)]
     public class ClientRpcAttribute : RpcAttribute
     {
+        /// <summary>
+        /// Initializes a new instance of ClientRpcAttribute configured to target all non-server clients
+        /// </summary>
         public ClientRpcAttribute() : base(SendTo.NotServer)
         {