Skip to content

Commit 7a81722

Browse files
ci: Integrating CodeCov with NGO repo [develop] (#3476)
Recently CodeCov was improved to also work for GitHub.com repositories so we can finally update the configuration to upload our results. This PR should be merged after we will be done with ongoing release process because it may require some corrections in the way how CodeCov comments will work so I don't want to block any ongoing work ## Backport This is ported to `develop-2.0.0` branch in #3474. Note that it will not affect `develop-2.0.0` branch since the configuration is being taken from default branch (currently `develop`) but when in the future we will switch the default branch then the configuration will already be there --------- Co-authored-by: Noel Stephens <noel.stephens@unity3d.com>
1 parent 977f854 commit 7a81722

File tree

2 files changed

+48
-2
lines changed

2 files changed

+48
-2
lines changed

.github/codecov.yml

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
codecov:
2+
require_ci_to_pass: false
3+
notify:
4+
wait_for_ci: true
5+
6+
coverage:
7+
precision: 2
8+
round: down
9+
range: "50...70"
10+
status:
11+
patch:
12+
default:
13+
if_ci_failed: success
14+
informational: true
15+
default_rules:
16+
flag_coverage_not_uploaded_behavior: exclude
17+
project:
18+
default:
19+
target: auto
20+
# Threshold used for the PR Check
21+
threshold: 0.5%
22+
base: auto
23+
if_ci_failed: success
24+
informational: true
25+
only_pulls: true
26+
27+
# PR Comment configuration
28+
comment:
29+
layout: "diff, flags, files, components"
30+
behavior: default
31+
require_changes: false
32+
require_base: false
33+
require_head: false
34+
# Set this to the number of coverage jobs run in the PR
35+
after_n_builds: 1
36+
37+
flag_management:
38+
default_rules:
39+
carryforward: true
40+
41+
# Components configuration
42+
component_management:
43+
individual_components:
44+
- component_id: "com.unity.netcode.gameobjects"
45+
name: "com.unity.netcode.gameobjects"
46+
paths:
47+
- com.unity.netcode.gameobjects

.yamato/code-coverage.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
# In order to properly use -coverage-results-path parameter we need to start it with $PWD (which means the absolute path). Otherwise, coverage results will not be visible
2222

2323
# QUALITY CONSIDERATIONS--------------------------------------------------------------------
24-
# TODO: somewhere in 2025 we will be able to upload resuls to CodeCov from public repos
2524
# To see where this job is included (in trigger job definitions) look into _triggers.yml file
2625

2726

@@ -39,7 +38,7 @@ code_coverage_{{ platform.name }}_{{ editor }}:
3938
commands:
4039
- unity-downloader-cli --fast --wait -u {{ editor }} -c Editor {% if platform.name == "mac" %} --arch arm64 {% endif %} # For macOS we use ARM64 models
4140
- upm-pvp create-test-project test-project --packages "upm-ci~/packages/*.tgz" --unity .Editor
42-
- UnifiedTestRunner --suite=editor --suite=playmode --editor-location=.Editor --testproject=test-project --enable-code-coverage -coverage-results-path=$PWD/test-results/CodeCoverage --coverage-options="generateHtmlReport;generateAdditionalMetrics;assemblyFilters:+Unity.Netcode.Editor,+Unity.Netcode.Runtime" --extra-editor-arg=--burst-disable-compilation --timeout=1800 --reruncount=1 --clean-library-on-rerun --artifacts-path=test-results
41+
- UnifiedTestRunner --suite=editor --suite=playmode --editor-location=.Editor --testproject=test-project --enable-code-coverage coverage-upload-options="reportsDir:$PWD/test-results/CoverageResults;name:NGOv1_{{ platform.name }}_{{ editor }};flags:NGOv1_{{ platform.name }}_{{ editor }};verbose" --coverage-results-path=$PWD/test-results/CoverageResults --coverage-options="generateHtmlReport;generateAdditionalMetrics;assemblyFilters:+Unity.Netcode.Editor,+Unity.Netcode.Runtime" --extra-editor-arg=--burst-disable-compilation --timeout=1800 --reruncount=1 --clean-library-on-rerun --artifacts-path=test-results
4342
artifacts:
4443
logs:
4544
paths:

0 commit comments

Comments
 (0)