Skip to content

Update get-started-with-ngo.md #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

dzhan008
Copy link

  • Update HelloWorldManager.cs code snippet to fix build errors
  • Moved/updated some text for better instruction flow
  • Added notes for extra clarity

WARNING: Please make your PR against the develop branch.


Select the type of change:

  • Small Changes - Typos, formatting, slight revisions
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, and new packages for the site and Docusaurus

Purpose of the Pull Request:

I finished this quickstart guide recently but ran into some issues throughout the tutorial. I wanted to address updates to this page to better help the flow of going through this part of the docs. Here are the details of what I changed:

  • Updated the HelloWorldManager.cs example with the following:
    • NetworkManager is now static, as it caused build errors with other static methods and probably should be its own instance anyway
    • Commented references to SubmitNewPosition() since HelloWorldPlayer.cs is not introduced until later in the tutorial, but before building for other steps
  • In Test the RPCs section, I removed the build steps and replaced it with setting up Multiplayer Play Mode. You can't see logs through builds unless you enable development builds, and even then only Debug.LogError is displayed
  • Updated outdated MPMM links
  • Added some new notes for clarity, including one where you don't need to update the NetworkVariable position in HelloWorldPlayer.cs anymore since technically NetworkTransform handles this out of box

As a note, with Unity 6 out some of the general for creating scripts/running builds are slightly different now. I held off on these changes since they were small, but wanted to bring this up for awareness.

Issue Number: N/A

jabbacakes and others added 3 commits December 17, 2024 13:39
Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>
Co-authored-by: Vic Cooper <vic.cooper@unity3d.com>
Co-authored-by: JiaRen <jia.ren@unity3d.com>
Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>
Co-authored-by: Vic Cooper <vic.cooper@unity3d.com>
Co-authored-by: JiaRen <jia.ren@unity3d.com>
- Update HelloWorldManager.cs code snippet to fix build errors
- Moved/updated some text for better instruction flow
- Added notes for extra clarity
@unity-cla-assistant
Copy link

unity-cla-assistant commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

@dzhan008 dzhan008 changed the base branch from main to develop January 14, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants