updating code samples that uses outdated version of CurrentPlayer.ReadOnlyTags #1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Return value of CurrentPlayer.ReadOnlyTags has been changed from `IReadOnlyCollection<string>` to `string[]` since 1.0.0. As `string[]` doesn't have `.Contains()` method, it should be adjusted.
Cj-bc
force-pushed
the
mppm/update-usage-of-readonlytags
branch
from
6caa2e9 to
89a6dc2
Compare
|
@Vic-Cooper This is an MPPM update - could you get someone from the dev team to verify it before we merge? |
kpurcellunity
approved these changes
Apr 17, 2025
There was a problem hiding this comment.
I think System.Ling is a valid way to get a contains method for string[] , this change seems good. Also not sure about the question regarding updating the other docs too. Do you know which docs they are referring to? @jabbacakes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select the type of change:
Purpose of the Pull Request:
Return value of CurrentPlayer.ReadOnlyTags has been changed from
IReadOnlyCollection<string>(in Multiplayer Play mode 0.6.0) tostring[]since 1.0.0. Asstring[]doesn't have.Contains()method, it should be adjusted.I would like to ask few things:
System.Linq. If it's better to do in another way, I'll do so.mppm_versioned_docs/version-1.*too?Issue Number:
Nothing.