This repository was archived by the owner on Sep 4, 2024. It is now read-only.
Reduce False Positive alarms #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyborn
requested review from
ConjunctiveNormalForm,
zhongeric,
marktoda and
hensha256
as code owners
zhongeric
approved these changes
May 10, 2024
bin/stacks/api-stack.ts
Outdated
| label: 'Latency Alarm', | ||
| usingMetrics: { | ||
| ura_high_latency: new aws_cloudwatch.MathExpression({ | ||
| expression: "IF(overall_latency > 7000, 1, 0)", |
There was a problem hiding this comment.
nit: would be nice to put these numbers into constants (URA_LATENCY_SEV3 = 7000, ROUTING_API_LATENCY_SEV3 = 4000, etc.) so we can change them all in one place
There was a problem hiding this comment.
Great callout! Moved these magic numbers to the constants file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is part of an effort to reduce noise in our operations alerting. If deployed 2 weeks ago, we'd have 10x less incidents from URA.
URA is the biggest contributor to our oncall incidents (sampling the last 25 incidents).
10/12 URA alarms were
UnifiedRoutingAPI-SEV2-LatencyP99.Most of these were caused by the Routing API (a dependency of URA) having a spike in latency. There is usually no action we can take and this adds to the noise.
This PR proposes two changes:
This is what the new conditional alerts look like when deployed:
