Skip to content

fix(v4-sdk): type compatibility in encoding functions for ethers #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

fix(v4-sdk): type compatibility in encoding functions for ethers #406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions sdks/v4-sdk/src/PositionManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,10 @@ export abstract class V4PositionManager {

// Encode a modify liquidities call
public static encodeModifyLiquidities(unlockData: string, deadline: BigintIsh): string {
return V4PositionManager.INTERFACE.encodeFunctionData(PositionFunctions.MODIFY_LIQUIDITIES, [unlockData, deadline])
return V4PositionManager.INTERFACE.encodeFunctionData(PositionFunctions.MODIFY_LIQUIDITIES, [
unlockData,
deadline.toString(),
])
}

// Encode a permit batch call
Expand All @@ -460,9 +463,9 @@ export abstract class V4PositionManager {
): string {
return V4PositionManager.INTERFACE.encodeFunctionData(PositionFunctions.ERC721PERMIT_PERMIT, [
spender,
tokenId,
deadline,
nonce,
tokenId.toString(),
deadline.toString(),
nonce.toString(),
signature,
])
}
Expand Down