-
Notifications
You must be signed in to change notification settings - Fork 5
Allow running without zino.toml #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
33ea83f
to
3edcf69
Compare
Test results666 tests 665 ✅ 28s ⏱️ For more details on these failures, see this check. Results for commit ddb3060. ♻️ This comment has been updated with latest results. |
3edcf69
to
e080251
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
==========================================
+ Coverage 98.71% 98.79% +0.08%
==========================================
Files 83 83
Lines 10092 10093 +1
==========================================
+ Hits 9962 9971 +9
+ Misses 130 122 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e080251
to
ddb3060
Compare
|
NTS: this is harder than I thought. Move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really, this is just a lot of faffing about. The code was already designed to run without a config file, but the main()
method used an incorrect reference to the running config.
#466 is my suggestion for an alternative to this PR.
config_dict["polling"]["file"] = poll_file_name | ||
|
||
config = Configuration.model_validate(obj=config_dict, strict=True) | ||
config = Configuration().model_validate(obj=config_dict, strict=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
model_validate()
is a classmethod. Why did you change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got an error when running tests.
Scope and purpose
Fixes #458
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.