Skip to content

Conversation

johannaengland
Copy link
Contributor

This can happen when for multiple python versions tests fail only on some.

When rerunning only these failing tests it leads to these files already existing and it waits for confirmation to override these files.
So we force this override so that this action doesn't fail.

Previously done in Uninett/Argus#835 and Uninett/nav#2975, but since this happened here now once as well I thought it might be good to introduce it.

Example for this happening: https://github.com/Uninett/netsnmp-cffi/actions/runs/17263574293/job/48990440212

@johannaengland johannaengland self-assigned this Aug 27, 2025
Copy link

github-actions bot commented Aug 27, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Aug 27, 2025

Test results

 4 files   4 suites   40s ⏱️
24 tests 24 ✅ 0 💤 0 ❌
96 runs  96 ✅ 0 💤 0 ❌

Results for commit 9895faa.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.05%. Comparing base (4120d26) to head (9895faa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   72.05%   72.05%           
=======================================
  Files          10       10           
  Lines        1256     1256           
=======================================
  Hits          905      905           
  Misses        351      351           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lunkwill42
Copy link
Member

Tests failed, and I can't quite see why this would affect that. Dependency issues perhaps?

@lunkwill42
Copy link
Member

The failing tests seem to be specifically smidump-related tests on Python 3.12.. this sounds eerily similar to what @hmpf is experiencing in Uninett/nav#3266

This can happen when for multiple python versions tests fail only on some
When rerunning only these failing tests it leads to these files already existing and it waits for confirmation to override these files
So we force this override so that this action doesn't fail
@lunkwill42 lunkwill42 force-pushed the workflows/override-zip-on-unpacking branch from 6317fc5 to 9895faa Compare September 4, 2025 12:53
@lunkwill42 lunkwill42 merged commit 62854d5 into master Sep 4, 2025
8 of 9 checks passed
@lunkwill42 lunkwill42 deleted the workflows/override-zip-on-unpacking branch September 4, 2025 12:55
@lunkwill42
Copy link
Member

Fixed by increasing timeouts. Rebased to master for changes to take effect also here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants