Skip to content

Drop support for Django 5.0, 5.1 and 4.2 #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 14, 2025
Merged

Drop support for Django 5.0, 5.1 and 4.2 #941

merged 10 commits into from
May 14, 2025

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Nov 12, 2024 •
edited
Loading

Depends on #940

Django 5.1 has some new forms-features I'd love to use.

@hmpf hmpf added dependencies Run `tox -r` before testing locally, dependencies have changed python Pull requests that update Python code labels Nov 12, 2024
@hmpf hmpf self-assigned this Nov 12, 2024
@hmpf hmpf changed the title Drop upport for Django 4.2 Drop support for Django 4.2 Nov 12, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hmpf hmpf added the paused Assignee is busy with things of higher priority label Dec 9, 2024
@hmpf hmpf force-pushed the drop-django42 branch 3 times, most recently from 74219e3 to f5218f9 Compare April 2, 2025 12:01
@hmpf hmpf force-pushed the drop-django42 branch 3 times, most recently from d78a6f2 to 183b23f Compare April 3, 2025 10:29
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.55%. Comparing base (820b53a) to head (37a0ebb).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
+ Coverage   78.50%   78.55%   +0.04%     
==========================================
  Files         142      142              
  Lines        5867     5879      +12     
==========================================
+ Hits         4606     4618      +12     
  Misses       1261     1261

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hmpf hmpf added the Argus v2 label May 12, 2025
@hmpf hmpf force-pushed the drop-django42 branch 3 times, most recently from fb77b5e to dc5d684 Compare May 13, 2025 07:54
johannaengland
johannaengland approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added one fixup commit and two more commits myself, feel free to change or remove them if you don't like them

Someone else should have another look at this since I made changes

@github-project-automation github-project-automation bot moved this from ❓ Ready for review to 👍 Reviewer approved in Argus development, public May 13, 2025
@johannaengland
Copy link
Contributor

And a news fragment is needed

@johannaengland
Copy link
Contributor

Isn't this also dropping support for Django 5.0 and 5.1? Then the title needs to be changed

lunkwill42
lunkwill42 requested changes May 13, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from 👍 Reviewer approved to ♻ Changes requested in Argus development, public May 13, 2025
@hmpf hmpf changed the title Drop support for Django 4.2 Drop support for Django 5.0, 5.1 and 4.2 May 14, 2025
@github-project-automation github-project-automation bot moved this from ♻ Changes requested to 👍 Reviewer approved in Argus development, public May 14, 2025
johannaengland
johannaengland approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only wish left is a news fragment 🙂

hmpf
hmpf commented May 14, 2025
View reviewed changes
src/argus/incident/templates/incident/admin/widgets/split_datetime_infinity.html
Copy link
Contributor Author

@hmpf hmpf May 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment might no longer be correct, 5.2 might be using its new fancy forms-features and stuph here. Lets not change the comment until we actually update to do things 5.2-style. The link is useful to find if there has been any changes after all.

@hmpf hmpf force-pushed the drop-django42 branch from 4d88154 to 9444ffb Compare May 14, 2025 08:43
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hmpf hmpf merged commit e6eadbb into Uninett:master May 14, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer approved to ✅ Done in Argus development, public May 14, 2025
@hmpf hmpf deleted the drop-django42 branch May 14, 2025 08:51
@johannaengland johannaengland mentioned this pull request May 15, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

@johannaengland johannaengland johannaengland approved these changes

@stveit stveit Awaiting requested review from stveit

@podliashanyk podliashanyk Awaiting requested review from podliashanyk

+1 more reviewer

@elfjes elfjes elfjes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hmpf hmpf

Labels

Argus v2 dependencies Run `tox -r` before testing locally, dependencies have changed paused Assignee is busy with things of higher priority python Pull requests that update Python code

Projects

Argus development, public
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hmpf @codecov-commenter @johannaengland @lunkwill42 @elfjes