Skip to content

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Mar 18, 2024

Document Argus's fundamental design philosophy in order to head off certain features at the pass.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.43%. Comparing base (8a3e712) to head (ccf5da8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #737   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files          73       73           
  Lines        3608     3608           
=======================================
  Hits         2866     2866           
  Misses        742      742           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 18, 2024

Test results

       7 files     511 suites   19m 33s ⏱️
   408 tests    407 ✔️ 1 💤 0
2 856 runs  2 849 ✔️ 7 💤 0

Results for commit ccf5da8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typo fixes and small comments, not a proper full review


Argus was started to solve three problems:

1. To aggregate/collect incidents from multiple NAV's without having to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a link to NAV here for people who don't know of NAV?

never allow the full expressitivity
.. [2] There is no way to send notifications for ALL incidents/events. The
closes you can get is sending for all stateful incidents, which will then
not allow sending for stateless incidents.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, if we decide to merge #701 it will be possible to send notifications for everything by having all event types in the filter

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hmpf hmpf added the paused Assignee is busy with things of higher priority label Dec 11, 2024
hmpf and others added 2 commits April 1, 2025 13:33
Co-authored-by: Johanna England <johanna.england@sikt.no>
Copy link

sonarqubecloud bot commented Apr 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

paused Assignee is busy with things of higher priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants