-
Notifications
You must be signed in to change notification settings - Fork 15
Document design philosophy #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #737 +/- ##
=======================================
Coverage 79.43% 79.43%
=======================================
Files 73 73
Lines 3608 3608
=======================================
Hits 2866 2866
Misses 742 742 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few typo fixes and small comments, not a proper full review
|
||
Argus was started to solve three problems: | ||
|
||
1. To aggregate/collect incidents from multiple NAV's without having to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a link to NAV here for people who don't know of NAV?
never allow the full expressitivity | ||
.. [2] There is no way to send notifications for ALL incidents/events. The | ||
closes you can get is sending for all stateful incidents, which will then | ||
not allow sending for stateless incidents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, if we decide to merge #701 it will be possible to send notifications for everything by having all event types in the filter
|
Co-authored-by: Johanna England <johanna.england@sikt.no>
|
Document Argus's fundamental design philosophy in order to head off certain features at the pass.