Skip to content

Conversation

Simrayz
Copy link
Contributor

@Simrayz Simrayz commented Oct 8, 2025

Scope and purpose

This PR adds a new tailwind-watch rule to the Makefile. It runs the tailwind CLI in watch mode, so the css is automatically updated when changing usage of classes in html file.

I also changed the tailwind rule to explicitly use the tailwind binary in the tailwind directory, instead of the "default" binary. Since I was using tailwindcss as a global CLI, it conflicted with the current implementation.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • [x The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this results in changes to the database model: Updated the ER diagram

@Simrayz Simrayz requested a review from a team October 8, 2025 12:56
@Simrayz Simrayz self-assigned this Oct 8, 2025
@Simrayz Simrayz added the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label Oct 8, 2025
Copy link

github-actions bot commented Oct 8, 2025

Test results

    4 files    468 suites   17m 29s ⏱️
  565 tests   564 ✅ 1 💤 0 ❌
2 260 runs  2 256 ✅ 4 💤 0 ❌

Results for commit d5a2e70.

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.45%. Comparing base (3bd147b) to head (f0590cf).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1560   +/-   ##
=======================================
  Coverage   78.45%   78.45%           
=======================================
  Files         124      124           
  Lines        5458     5458           
=======================================
  Hits         4282     4282           
  Misses       1176     1176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -1 +1 @@
.PHONY: clean testclean distclean coverageclean cacheclean nuke tailwind docclean upgrade-tailwind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the new rule to .PHONY

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐴

@Simrayz Simrayz force-pushed the add-tailwind-watch-rule branch from d5a2e70 to f0590cf Compare October 10, 2025 08:12
Copy link

@Simrayz Simrayz requested a review from hmpf October 10, 2025 08:13
@hmpf hmpf merged commit e6ef2e4 into master Oct 10, 2025
17 checks passed
@hmpf
Copy link
Contributor

hmpf commented Oct 10, 2025

The rule change is also done in the tailwind upgrade branch! It is probably not the only thing that happens in that branch that ought to be split out =)

@hmpf hmpf deleted the add-tailwind-watch-rule branch October 10, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants