-
Notifications
You must be signed in to change notification settings - Fork 15
Add tailwind-watch rule and use local cli explicitly #1560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test results 4 files 468 suites 17m 29s ⏱️ Results for commit d5a2e70. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1560 +/- ##
=======================================
Coverage 78.45% 78.45%
=======================================
Files 124 124
Lines 5458 5458
=======================================
Hits 4282 4282
Misses 1176 1176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -1 +1 @@ | |||
.PHONY: clean testclean distclean coverageclean cacheclean nuke tailwind docclean upgrade-tailwind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add the new rule to .PHONY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🐴
d5a2e70
to
f0590cf
Compare
|
The rule change is also done in the tailwind upgrade branch! It is probably not the only thing that happens in that branch that ought to be split out =) |
Scope and purpose
This PR adds a new
tailwind-watch
rule to theMakefile
. It runs the tailwind CLI in watch mode, so the css is automatically updated when changing usage of classes in html file.I also changed the
tailwind
rule to explicitly use the tailwind binary in the tailwind directory, instead of the "default" binary. Since I was using tailwindcss as a global CLI, it conflicted with the current implementation.Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.