Skip to content

Conversation

johannaengland
Copy link
Contributor

Scope and purpose

Reference: https://docs.codecov.com/docs/commit-status#threshold

Currently the codecov check will succeed even on a 90% drop in coverage. I think 10% drop was the intended target, but we can of course discuss about the specific number.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
    used the https://codecov.io/validate API endpoint to validate the config file
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to

@johannaengland johannaengland requested a review from a team August 11, 2025 08:15
@johannaengland johannaengland self-assigned this Aug 11, 2025
@johannaengland johannaengland added DevEx nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) labels Aug 11, 2025
Copy link

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@4f62a2a). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1528   +/-   ##
=========================================
  Coverage          ?   78.93%           
=========================================
  Files             ?      121           
  Lines             ?     5427           
  Branches          ?        0           
=========================================
  Hits              ?     4284           
  Misses            ?     1143           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that a 10% decrease in coverage in a single PR is pretty steep. Current CLOC of Argus seems to be slighty above 9400. 10% of that would be 940 lines...

@johannaengland
Copy link
Contributor Author

I'd say that a 10% decrease in coverage in a single PR is pretty steep. Current CLOC of Argus seems to be slighty above 9400. 10% of that would be 940 lines...

I agree, 1% then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DevEx nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants