-
Notifications
You must be signed in to change notification settings - Fork 15
Forms for incident list refresh info #1514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1514 +/- ##
==========================================
+ Coverage 79.46% 79.54% +0.08%
==========================================
Files 121 122 +1
Lines 5425 5511 +86
==========================================
+ Hits 4311 4384 +73
- Misses 1114 1127 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
def filter(self, queryset): | ||
timeframe = self.get_clean_value() | ||
if timeframe: | ||
after = tznow() - timedelta(seconds=timeframe * 60) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make it more explicit that timeframe is in minutes
after = tznow() - timedelta(seconds=timeframe * 60) | |
after = tznow() - timedelta(minutes=timeframe) |
Scope and purpose
Replaces #1385
Fixes #1382
Depends on #1512
Adds consistency and validation to ALL recognized GET-parameters on the incident list page.
With Django 5.2 we could go a step further in cleaning up this, some code taken from #1385. There should be no visible changes or changes to UX.
First step is #1512
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.