Skip to content

Conversation

elfjes
Copy link
Contributor

@elfjes elfjes commented Apr 21, 2025

Scope and purpose

Argus uses SMTPS 587 for email by default (in settings/base.py). This is a non-obvious default which may confuse third party developers/users (it confused me). This PR sets the default to the more obvious default SMTP 25 (which are also the django settings) and instead sets the Sikt Argus specific defaults (SMTPS 587) in settings/prod.py

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this results in changes to the database model: Updated the ER diagram

Copy link

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.53%. Comparing base (3242651) to head (bb25342).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1395   +/-   ##
=======================================
  Coverage   78.53%   78.53%           
=======================================
  Files         142      142           
  Lines        5862     5862           
=======================================
  Hits         4604     4604           
  Misses       1258     1258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hmpf hmpf moved this from 📋 Backlog to ❓ Ready for review in Argus development, public Apr 22, 2025
@hmpf hmpf added the change setting Name, location or default value of a setting was changed label Apr 22, 2025
@hmpf hmpf self-requested a review April 22, 2025 05:46
@github-project-automation github-project-automation bot moved this from ❓ Ready for review to 👍 Reviewer approved in Argus development, public Apr 22, 2025
@hmpf hmpf merged commit 85a48c0 into Uninett:master Apr 22, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer approved to ✅ Done in Argus development, public Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change setting Name, location or default value of a setting was changed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants