Skip to content

Conversation

johannaengland
Copy link
Contributor

No description provided.

@johannaengland johannaengland self-assigned this Jan 22, 2025
@johannaengland johannaengland force-pushed the active-search-tags branch 3 times, most recently from 1043324 to 49d367e Compare January 22, 2025 09:30
Copy link

github-actions bot commented Jan 22, 2025

Test results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 09a2498.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 34.48276% with 19 lines in your changes missing coverage. Please review.

Project coverage is 78.19%. Comparing base (b969ae6) to head (e49f1ce).

Files with missing lines Patch % Lines
src/argus/htmx/incident/filter.py 33.33% 12 Missing ⚠️
src/argus/htmx/incident/views.py 22.22% 7 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           filter-incidents-tags-dropdown    #1146      +/-   ##
==================================================================
- Coverage                           78.44%   78.19%   -0.25%     
==================================================================
  Files                                 141      141              
  Lines                                5446     5472      +26     
==================================================================
+ Hits                                 4272     4279       +7     
- Misses                               1174     1193      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland force-pushed the filter-incidents-tags-dropdown branch from dc7b986 to 5be496b Compare January 22, 2025 12:14
@johannaengland johannaengland force-pushed the active-search-tags branch 2 times, most recently from 5e34b8d to dee59a6 Compare January 23, 2025 12:38
@johannaengland johannaengland force-pushed the filter-incidents-tags-dropdown branch from 5be496b to b969ae6 Compare January 23, 2025 12:41
@johannaengland johannaengland force-pushed the active-search-tags branch 2 times, most recently from d2a682f to 751b203 Compare January 28, 2025 13:36
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@hmpf
Copy link
Contributor

hmpf commented Jan 29, 2025

So I've played around to see what happens given a fixed set of tags. In the commit "test: try with initial" I set form.initial to one specific tag.

On first click in the search box I get, as usual:

image

But on the second click I get:

image

(Had to go via my cell phone to get this.)

WAT.

I expected one line with "location=argus"...

@hmpf
Copy link
Contributor

hmpf commented Jan 29, 2025

@johannaengland johannaengland force-pushed the filter-incidents-tags-dropdown branch 2 times, most recently from e344fc3 to aa383f9 Compare March 5, 2025 10:34
Base automatically changed from filter-incidents-tags-dropdown to master March 5, 2025 12:30
@johannaengland johannaengland added the paused Assignee is busy with things of higher priority label Mar 5, 2025
@johannaengland
Copy link
Contributor Author

Setting this to paused for now, since it is much more difficult than expected and #1141 at least implemented filtering by tags using a simple text field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

paused Assignee is busy with things of higher priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants