-
Notifications
You must be signed in to change notification settings - Fork 11
Refactor colorbar loc handling #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor colorbar loc handling #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add a test for this by adding an image to our image comparison tests?
Yes. Hold on. It's a bit tricky as the vert bars suffer from looking bad if you open the figure in gtk but look good on save |
Was drafting a release and noticed this |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Need to fix the framing for the inset |
Ok I sat down and went through all the edge cases but I think I got it looking relatively nice now. I am afraid, however, that the tests will indicate a visual difference since the logic is now concerning all the locations for insets. |
The resulting tests look good but differ in shape. Not sure why but likely related to the newly added refactors. Otherwise visually looks good. |
See above for changes @beckermr |
minor adjustment of #301This PR is now a refactor of how the label positioning is handled. It moves the ugly block to a much easier to read helper function with some internal checking.
Important changes:
I will need to add some tests to test this properly and still adjust the bbox handling with this new approach.