Skip to content

Chore: improvements for ticket classification sample #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

radu-mocanu
Copy link
Contributor

@radu-mocanu radu-mocanu commented Apr 3, 2025

ToDo:

  • create new app

@radu-mocanu radu-mocanu requested a review from cristipufu April 3, 2025 10:30
@radu-mocanu radu-mocanu self-assigned this Apr 3, 2025
@radu-mocanu radu-mocanu force-pushed the feat/ticket-classification-sample-improvements branch 3 times, most recently from 9670e2d to 32375ce Compare April 3, 2025 12:35
@radu-mocanu radu-mocanu changed the title [WIP ]Samples: improvements for ticket classification sample [WIP] Samples: improvements for ticket classification sample Apr 3, 2025
@radu-mocanu radu-mocanu force-pushed the feat/ticket-classification-sample-improvements branch from 32375ce to 25a3569 Compare April 3, 2025 12:38
@radu-mocanu radu-mocanu changed the title [WIP] Samples: improvements for ticket classification sample Samples: improvements for ticket classification sample Apr 3, 2025
@radu-mocanu radu-mocanu force-pushed the feat/ticket-classification-sample-improvements branch from 25a3569 to 2a0de3f Compare April 3, 2025 13:57
@radu-mocanu radu-mocanu changed the title Samples: improvements for ticket classification sample [WIP]Samples: improvements for ticket classification sample Apr 3, 2025
@radu-mocanu radu-mocanu force-pushed the feat/ticket-classification-sample-improvements branch 3 times, most recently from 47514cf to e1c2b6f Compare April 4, 2025 11:02
@radu-mocanu radu-mocanu changed the title [WIP]Samples: improvements for ticket classification sample Chore: improvements for ticket classification sample Apr 4, 2025
@radu-mocanu radu-mocanu force-pushed the feat/ticket-classification-sample-improvements branch from e1c2b6f to 9a022ff Compare April 4, 2025 11:05
@@ -87,51 +94,77 @@ async def classify(state: GraphState) -> GraphState:
azure_endpoint=os.getenv("AZURE_OPENAI_ENDPOINT"),
api_version="2024-10-21"
)
new_state = GraphState(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to change GraphState to class GraphState(MessagesState): and use state.messages.append(HumanMessage()) to inform the LLM of rejected categories

@radu-mocanu radu-mocanu closed this Apr 7, 2025
@gheorghitahurmuz gheorghitahurmuz deleted the feat/ticket-classification-sample-improvements branch April 10, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants